Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(470)

Unified Diff: content/common/media/media_devices.cc

Issue 2703393007: Show meaningful name for cameras (Closed)
Patch Set: fix trybot Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/common/media/media_devices.h ('k') | extensions/strings/extensions_strings.grd » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/common/media/media_devices.cc
diff --git a/content/common/media/media_devices.cc b/content/common/media/media_devices.cc
index 80661916fe8d8e8a30c3fb77b439ab53dfe61467..5eb8a1843beaba0f1e24ed9135b1426b2674ebfe 100644
--- a/content/common/media/media_devices.cc
+++ b/content/common/media/media_devices.cc
@@ -8,7 +8,8 @@
namespace content {
-MediaDeviceInfo::MediaDeviceInfo() = default;
+MediaDeviceInfo::MediaDeviceInfo()
+ : video_facing(media::VideoFacingMode::MEDIA_VIDEO_FACING_NONE) {}
MediaDeviceInfo::MediaDeviceInfo(const MediaDeviceInfo& other) = default;
@@ -17,17 +18,23 @@ MediaDeviceInfo::MediaDeviceInfo(MediaDeviceInfo&& other) = default;
MediaDeviceInfo::MediaDeviceInfo(const std::string& device_id,
const std::string& label,
const std::string& group_id)
- : device_id(device_id), label(label), group_id(group_id) {}
+ : device_id(device_id),
+ label(label),
+ group_id(group_id),
+ video_facing(media::VideoFacingMode::MEDIA_VIDEO_FACING_NONE) {}
MediaDeviceInfo::MediaDeviceInfo(
const media::AudioDeviceDescription& device_description)
: device_id(device_description.unique_id),
label(device_description.device_name),
- group_id(device_description.group_id) {}
+ group_id(device_description.group_id),
+ video_facing(media::VideoFacingMode::MEDIA_VIDEO_FACING_NONE) {}
MediaDeviceInfo::MediaDeviceInfo(
const media::VideoCaptureDeviceDescriptor& descriptor)
- : device_id(descriptor.device_id), label(descriptor.GetNameAndModel()) {}
+ : device_id(descriptor.device_id),
+ label(descriptor.GetNameAndModel()),
+ video_facing(descriptor.facing) {}
MediaDeviceInfo::~MediaDeviceInfo() = default;
« no previous file with comments | « content/common/media/media_devices.h ('k') | extensions/strings/extensions_strings.grd » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698