Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Side by Side Diff: content/common/media/media_devices.cc

Issue 2703393007: Show meaningful name for cameras (Closed)
Patch Set: fix trybot Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « content/common/media/media_devices.h ('k') | extensions/strings/extensions_strings.grd » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/common/media/media_devices.h" 5 #include "content/common/media/media_devices.h"
6 #include "media/audio/audio_device_description.h" 6 #include "media/audio/audio_device_description.h"
7 #include "media/capture/video/video_capture_device_descriptor.h" 7 #include "media/capture/video/video_capture_device_descriptor.h"
8 8
9 namespace content { 9 namespace content {
10 10
11 MediaDeviceInfo::MediaDeviceInfo() = default; 11 MediaDeviceInfo::MediaDeviceInfo()
12 : video_facing(media::VideoFacingMode::MEDIA_VIDEO_FACING_NONE) {}
12 13
13 MediaDeviceInfo::MediaDeviceInfo(const MediaDeviceInfo& other) = default; 14 MediaDeviceInfo::MediaDeviceInfo(const MediaDeviceInfo& other) = default;
14 15
15 MediaDeviceInfo::MediaDeviceInfo(MediaDeviceInfo&& other) = default; 16 MediaDeviceInfo::MediaDeviceInfo(MediaDeviceInfo&& other) = default;
16 17
17 MediaDeviceInfo::MediaDeviceInfo(const std::string& device_id, 18 MediaDeviceInfo::MediaDeviceInfo(const std::string& device_id,
18 const std::string& label, 19 const std::string& label,
19 const std::string& group_id) 20 const std::string& group_id)
20 : device_id(device_id), label(label), group_id(group_id) {} 21 : device_id(device_id),
22 label(label),
23 group_id(group_id),
24 video_facing(media::VideoFacingMode::MEDIA_VIDEO_FACING_NONE) {}
21 25
22 MediaDeviceInfo::MediaDeviceInfo( 26 MediaDeviceInfo::MediaDeviceInfo(
23 const media::AudioDeviceDescription& device_description) 27 const media::AudioDeviceDescription& device_description)
24 : device_id(device_description.unique_id), 28 : device_id(device_description.unique_id),
25 label(device_description.device_name), 29 label(device_description.device_name),
26 group_id(device_description.group_id) {} 30 group_id(device_description.group_id),
31 video_facing(media::VideoFacingMode::MEDIA_VIDEO_FACING_NONE) {}
27 32
28 MediaDeviceInfo::MediaDeviceInfo( 33 MediaDeviceInfo::MediaDeviceInfo(
29 const media::VideoCaptureDeviceDescriptor& descriptor) 34 const media::VideoCaptureDeviceDescriptor& descriptor)
30 : device_id(descriptor.device_id), label(descriptor.GetNameAndModel()) {} 35 : device_id(descriptor.device_id),
36 label(descriptor.GetNameAndModel()),
37 video_facing(descriptor.facing) {}
31 38
32 MediaDeviceInfo::~MediaDeviceInfo() = default; 39 MediaDeviceInfo::~MediaDeviceInfo() = default;
33 40
34 MediaDeviceInfo& MediaDeviceInfo::operator=(const MediaDeviceInfo& other) = 41 MediaDeviceInfo& MediaDeviceInfo::operator=(const MediaDeviceInfo& other) =
35 default; 42 default;
36 43
37 MediaDeviceInfo& MediaDeviceInfo::operator=(MediaDeviceInfo&& other) = default; 44 MediaDeviceInfo& MediaDeviceInfo::operator=(MediaDeviceInfo&& other) = default;
38 45
39 bool operator==(const MediaDeviceInfo& first, const MediaDeviceInfo& second) { 46 bool operator==(const MediaDeviceInfo& first, const MediaDeviceInfo& second) {
40 return first.device_id == second.device_id && first.label == second.label; 47 return first.device_id == second.device_id && first.label == second.label;
41 } 48 }
42 49
43 } // namespace content 50 } // namespace content
OLDNEW
« no previous file with comments | « content/common/media/media_devices.h ('k') | extensions/strings/extensions_strings.grd » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698