Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(647)

Issue 2703373009: Make the tab scrubber speed proportional with the number of tabs (Closed)

Created:
3 years, 10 months ago by afakhry
Modified:
3 years, 10 months ago
Reviewers:
sky
CC:
chromium-reviews, kalyank, sadrul, tfarina
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make the tab scrubber speed proportional with the number of tabs When the number of tabs increases, tab scrubbing speed becomes too fast that it's very hard to target a specific tab. This CL makes the speed proportional with the number of tabs. BUG=678316 TEST=When you add a lot of tabs, tab scrubbing is still easy. Review-Url: https://codereview.chromium.org/2703373009 Cr-Commit-Position: refs/heads/master@{#452644} Committed: https://chromium.googlesource.com/chromium/src/+/e60c7cdab72dcbf2abdea65ab7ac74ee32f112b4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -1 line) Patch
M chrome/browser/ui/views/ash/tab_scrubber.cc View 3 chunks +13 lines, -1 line 0 comments Download

Messages

Total messages: 12 (8 generated)
afakhry
Sky, can you please take a look? Thank you!
3 years, 10 months ago (2017-02-23 19:21:47 UTC) #2
sky
LGTM
3 years, 10 months ago (2017-02-23 21:28:34 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2703373009/1
3 years, 10 months ago (2017-02-23 21:40:37 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-02-23 21:51:11 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e60c7cdab72dcbf2abdea65ab7ac...

Powered by Google App Engine
This is Rietveld 408576698