Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Issue 2703363004: Add an infobar if a session is being controlled by an automated test. (Closed)

Created:
3 years, 10 months ago by samuong
Modified:
3 years, 10 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

Add an infobar if a session is being controlled by an automated test. This infobar is only displayed if the browser is launched with the --enable-automation switch. It also disables the developer mode extensions warning bubble. Design doc: https://docs.google.com/document/d/1JYj9K61UyxIYavR8_HATYIglR9T_rDwAtLLsD3fbDQg/edit BUG=chromedriver:1625 TEST=launch with and without --enable-automation, and check for presence of automation infobar Review-Url: https://codereview.chromium.org/2564973002 Cr-Commit-Position: refs/heads/master@{#450257} (cherry picked from commit 7a66b24c10161a5db8668729a97ac95cee9068e2) Review-Url: https://codereview.chromium.org/2703363004 . Cr-Commit-Position: refs/branch-heads/2987@{#627} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/795fb79651648d3da7c538aafc2b548e25299912

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+123 lines, -21 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/ui/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/extensions/extension_message_bubble_factory.cc View 2 chunks +9 lines, -0 lines 0 comments Download
A chrome/browser/ui/startup/automation_infobar_delegate.h View 1 chunk +33 lines, -0 lines 0 comments Download
A chrome/browser/ui/startup/automation_infobar_delegate.cc View 1 chunk +41 lines, -0 lines 0 comments Download
M chrome/browser/ui/startup/startup_browser_creator_impl.cc View 2 chunks +10 lines, -1 line 0 comments Download
M chrome/common/chrome_switches.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/chrome_switches.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/test/chromedriver/chrome_launcher.cc View 1 chunk +17 lines, -20 lines 0 comments Download
M components/infobars/core/infobar_delegate.h View 1 chunk +1 line, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
samuong
3 years, 10 months ago (2017-02-21 23:08:49 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
795fb79651648d3da7c538aafc2b548e25299912.

Powered by Google App Engine
This is Rietveld 408576698