content/renderer/service_worker/service_worker_context_client.h - Issue 2703343002: ServiceWorker: Use mojo's data pipe for respondWith(stream)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/service_worker/service_worker_context_client.h

Issue 2703343002: ServiceWorker: Use mojo's data pipe for respondWith(stream) (Closed)

Patch Set: Addressed comments from kinuko and haraken Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/renderer/cache_storage/cache_storage_dispatcher.cc ('k') | content/renderer/service_worker/service_worker_context_client.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/service_worker/service_worker_context_client.h

diff --git a/content/renderer/service_worker/service_worker_context_client.h b/content/renderer/service_worker/service_worker_context_client.h

index 3ec1e599d71f8ac33818a1de5344908916283887..f73acbb0fe982c08b97a0d0af9eec142837e6f94 100644

--- a/content/renderer/service_worker/service_worker_context_client.h

+++ b/content/renderer/service_worker/service_worker_context_client.h

@@ -159,11 +159,16 @@ class ServiceWorkerContextClient : public blink::WebServiceWorkerContextClient,

void DidHandleInstallEvent(int request_id,

blink::WebServiceWorkerEventResult result,

double event_dispatch_time) override;

- void RespondToFetchEvent(int fetch_event_id,

- double event_dispatch_time) override;

+ void RespondToFetchEventWithNoResponse(int fetch_event_id,

+ double event_dispatch_time) override;

void RespondToFetchEvent(int fetch_event_id,

const blink::WebServiceWorkerResponse& response,

double event_dispatch_time) override;

+ void RespondToFetchEventWithResponseStream(

+ int fetch_event_id,

+ const blink::WebServiceWorkerResponse& response,

+ blink::WebServiceWorkerStreamHandle* web_body_as_stream,

+ double event_dispatch_time) override;

void DidHandleFetchEvent(int fetch_event_id,

blink::WebServiceWorkerEventResult result,

double dispatch_event_time) override;

@@ -246,10 +251,12 @@ class ServiceWorkerContextClient : public blink::WebServiceWorkerContextClient,

void DispatchExtendableMessageEvent(

mojom::ExtendableMessageEventPtr event,

const DispatchExtendableMessageEventCallback& callback) override;

- void DispatchFetchEvent(int fetch_event_id,

- const ServiceWorkerFetchRequest& request,

- mojom::FetchEventPreloadHandlePtr preload_handle,

- const DispatchFetchEventCallback& callback) override;

+ void DispatchFetchEvent(

+ int fetch_event_id,

+ const ServiceWorkerFetchRequest& request,

+ mojom::FetchEventPreloadHandlePtr preload_handle,

+ mojom::ServiceWorkerFetchResponseCallbackPtr response_callback,

+ const DispatchFetchEventCallback& callback) override;

void DispatchNotificationClickEvent(

const std::string& notification_id,

const PlatformNotificationData& notification_data,