content/renderer/cache_storage/cache_storage_dispatcher.cc - Issue 2703343002: ServiceWorker: Use mojo's data pipe for respondWith(stream)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/cache_storage/cache_storage_dispatcher.cc

Issue 2703343002: ServiceWorker: Use mojo's data pipe for respondWith(stream) (Closed)

Patch Set: Addressed comments from kinuko and haraken Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/cache_storage/cache_storage_dispatcher.cc

diff --git a/content/renderer/cache_storage/cache_storage_dispatcher.cc b/content/renderer/cache_storage/cache_storage_dispatcher.cc

index 6225a787b4cd5d83a09975b6e6de3cea1d85a043..51b09d23ca141b3c6205f567d61419a0e09f58ab 100644

--- a/content/renderer/cache_storage/cache_storage_dispatcher.cc

+++ b/content/renderer/cache_storage/cache_storage_dispatcher.cc

@@ -104,9 +104,6 @@ CacheStorageCacheOperationType CacheOperationTypeFromWebCacheOperationType(

CacheStorageBatchOperation BatchOperationFromWebBatchOperation(

const blink::WebServiceWorkerCache::BatchOperation& web_operation) {

- // We don't support streaming for cache.

- DCHECK(web_operation.response.StreamURL().IsEmpty());

CacheStorageBatchOperation operation;

operation.operation_type =

CacheOperationTypeFromWebCacheOperationType(web_operation.operation_type);