Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2703333005:
[Payments] Cancel edit after clicking back button (Closed)
|
Created:
3 years, 10 months ago by gogerald1 Modified:
3 years, 10 months ago Reviewers:
please use gerrit instead CC:
chromium-reviews, rouslan+payments_chromium.org, sebsg+paymentswatch_chromium.org, gogerald+paymentswatch_chromium.org, agrieve+watch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Description[Payments] Cancel edit after clicking back button
BUG=693901
Review-Url: https://codereview.chromium.org/2703333005
Cr-Commit-Position: refs/heads/master@{#451820}
Committed: https://chromium.googlesource.com/chromium/src/+/5f03b4e738fa6e41469e1c808634135a5fe1fdab
Patch Set 1 #
Total comments: 2
Patch Set 2 : minimize changes #Messages
Total messages: 17 (12 generated)
Description was changed from ========== cancel editor in EditorModel after clicking back button cancel editor after clicking back button cancel editor when clicking back button BUG= ========== to ========== cancel editor in EditorModel after clicking back button BUG=693901 ==========
gogerald@chromium.org changed reviewers: + rouslan@chromium.org
Hi rouslan@, PTAL,
The CQ bit was checked by gogerald@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== cancel editor in EditorModel after clicking back button BUG=693901 ========== to ========== [Payments] Cancel editor in EditorModel after clicking back button BUG=693901 ==========
Description was changed from ========== [Payments] Cancel editor in EditorModel after clicking back button BUG=693901 ========== to ========== [Payments] Cancel edit after clicking back button BUG=693901 ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
This patch LGTM % comment. To avoid regressions, please add a test similar to: https://cs.chromium.org/chromium/src/chrome/android/javatests/src/org/chromiu... But call "dispatchKeyEvent(new KeyEvent(KeyEvent.ACTION_DOWN, KeyEvent.KEYCODE_BACK))" instead of clicking the cancel button. The test should be added in a follow-up patch to ease merging of this patch to M-57. https://codereview.chromium.org/2703333005/diff/1/chrome/android/java/src/org... File chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorView.java (right): https://codereview.chromium.org/2703333005/diff/1/chrome/android/java/src/org... chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorView.java:386: } Since we'd like to merge this into M-57, let's try to minimize the number of changes. Please move this method back to where it was (after initFocus() method) to make the merge easier.
Thanks, test in the upcoming CL, https://codereview.chromium.org/2703333005/diff/1/chrome/android/java/src/org... File chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorView.java (right): https://codereview.chromium.org/2703333005/diff/1/chrome/android/java/src/org... chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorView.java:386: } On 2017/02/21 17:38:03, rouslan wrote: > Since we'd like to merge this into M-57, let's try to minimize the number of > changes. Please move this method back to where it was (after initFocus() method) > to make the merge easier. Done.
The CQ bit was checked by gogerald@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from rouslan@chromium.org Link to the patchset: https://codereview.chromium.org/2703333005/#ps20001 (title: "minimize changes")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1487700891338500,
"parent_rev": "f0b30fafe9d73f73c430895d289ab83c3e818d20", "commit_rev":
"5f03b4e738fa6e41469e1c808634135a5fe1fdab"}
Message was sent while issue was closed.
Description was changed from ========== [Payments] Cancel edit after clicking back button BUG=693901 ========== to ========== [Payments] Cancel edit after clicking back button BUG=693901 Review-Url: https://codereview.chromium.org/2703333005 Cr-Commit-Position: refs/heads/master@{#451820} Committed: https://chromium.googlesource.com/chromium/src/+/5f03b4e738fa6e41469e1c808634... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/5f03b4e738fa6e41469e1c808634... |
