Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issue 2703333003: Clamp the restore bounds to new workspace when a display is disconnected. (Closed)

Created:
3 years, 10 months ago by oshima
Modified:
3 years, 10 months ago
Reviewers:
afakhry
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Clamp the restore bounds to new workspace when a display is disconnected. Reparent does adjust the bounds, but when it's partially offline, i can push the window further to the different direction if the destination display is larger. BUG=659925 TEST=Updated the test to cover the scenario. Review-Url: https://codereview.chromium.org/2703333003 Cr-Commit-Position: refs/heads/master@{#451899} Committed: https://chromium.googlesource.com/chromium/src/+/92224ac504e06d16d48ceeb63eb3160519629ffc

Patch Set 1 #

Patch Set 2 : diff #

Total comments: 2

Patch Set 3 : removed unnnecessary checks #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -6 lines) Patch
M ash/root_window_controller.cc View 1 2 chunks +6 lines, -0 lines 0 comments Download
M ash/root_window_controller_unittest.cc View 1 2 3 chunks +12 lines, -6 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
oshima
3 years, 10 months ago (2017-02-21 08:27:22 UTC) #5
afakhry
https://codereview.chromium.org/2703333003/diff/60001/ash/root_window_controller_unittest.cc File ash/root_window_controller_unittest.cc (right): https://codereview.chromium.org/2703333003/diff/60001/ash/root_window_controller_unittest.cc#newcode177 ash/root_window_controller_unittest.cc:177: fullscreen->GetNativeView()->GetBoundsInRootWindow().ToString()); These EXPECT_EQ()s seem to be the exact same ...
3 years, 10 months ago (2017-02-21 17:42:51 UTC) #8
oshima
https://codereview.chromium.org/2703333003/diff/60001/ash/root_window_controller_unittest.cc File ash/root_window_controller_unittest.cc (right): https://codereview.chromium.org/2703333003/diff/60001/ash/root_window_controller_unittest.cc#newcode177 ash/root_window_controller_unittest.cc:177: fullscreen->GetNativeView()->GetBoundsInRootWindow().ToString()); On 2017/02/21 17:42:51, afakhry wrote: > These EXPECT_EQ()s ...
3 years, 10 months ago (2017-02-21 23:54:55 UTC) #9
afakhry
lgtm
3 years, 10 months ago (2017-02-21 23:56:09 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2703333003/80001
3 years, 10 months ago (2017-02-22 04:51:37 UTC) #12
commit-bot: I haz the power
3 years, 10 months ago (2017-02-22 06:28:39 UTC) #15
Message was sent while issue was closed.
Committed patchset #3 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/92224ac504e06d16d48ceeb63eb3...

Powered by Google App Engine
This is Rietveld 408576698