Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3594)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/webshare/ShareServiceImpl.java

Issue 2703333002: Web Share: Refactor Mojo interface to now return an enum error. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/webshare/ShareServiceImpl.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/webshare/ShareServiceImpl.java b/chrome/android/java/src/org/chromium/chrome/browser/webshare/ShareServiceImpl.java
index c7e9c0b942badc90993e9a86e39ce09db8c813ce..93b4a79903b0ca39ac873c8d15723355578fec5e 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/webshare/ShareServiceImpl.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/webshare/ShareServiceImpl.java
@@ -15,6 +15,7 @@ import org.chromium.content_public.browser.WebContents;
import org.chromium.mojo.system.MojoException;
import org.chromium.ui.base.WindowAndroid;
import org.chromium.url.mojom.Url;
+import org.chromium.webshare.mojom.ShareError;
import org.chromium.webshare.mojom.ShareService;
/**
@@ -56,7 +57,7 @@ public class ShareServiceImpl implements ShareService {
if (mActivity == null) {
RecordHistogram.recordEnumeratedHistogram("WebShare.ShareOutcome",
WEBSHARE_OUTCOME_UNKNOWN_FAILURE, WEBSHARE_OUTCOME_COUNT);
- callback.call("Share failed");
+ callback.call(ShareError.INTERNAL_ERROR);
return;
}
@@ -64,13 +65,13 @@ public class ShareServiceImpl implements ShareService {
public void onTargetChosen(ComponentName chosenComponent) {
RecordHistogram.recordEnumeratedHistogram("WebShare.ShareOutcome",
WEBSHARE_OUTCOME_SUCCESS, WEBSHARE_OUTCOME_COUNT);
- callback.call(null);
+ callback.call(ShareError.OK);
}
public void onCancel() {
RecordHistogram.recordEnumeratedHistogram("WebShare.ShareOutcome",
WEBSHARE_OUTCOME_CANCELED, WEBSHARE_OUTCOME_COUNT);
- callback.call("Share canceled");
+ callback.call(ShareError.CANCELED);
}
};

Powered by Google App Engine
This is Rietveld 408576698