third_party/WebKit/LayoutTests/webshare/resources/mock-share-service.js - Issue 2703333002: Web Share: Refactor Mojo interface to now return an enum error.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/webshare/resources/mock-share-service.js

Issue 2703333002: Web Share: Refactor Mojo interface to now return an enum error. (Closed)

Patch Set: Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/webshare/share_service_impl_unittest.cc ('k') | third_party/WebKit/LayoutTests/webshare/share-arity.html » ('j') | third_party/WebKit/Source/modules/webshare/NavigatorShare.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/webshare/resources/mock-share-service.js

diff --git a/third_party/WebKit/LayoutTests/webshare/resources/mock-share-service.js b/third_party/WebKit/LayoutTests/webshare/resources/mock-share-service.js

index 0e04983b5d29049b8d1b4cfec952d50d3a6102be..c6ae49b1dda025fde016350272e57ed27463fdb5 100644

--- a/third_party/WebKit/LayoutTests/webshare/resources/mock-share-service.js

+++ b/third_party/WebKit/LayoutTests/webshare/resources/mock-share-service.js

@@ -1,5 +1,7 @@

'use strict';

+let ShareError;

Sam McNally 2017/02/21 23:02:40 This is ugly. Consider passing webshare into the s

Matt Giuca 2017/02/23 04:18:37 Done. (I find that uglier... but whatever.)

let mockShareService = loadMojoModules(

'mockShareService',

['mojo/public/js/bindings',

@@ -7,6 +9,8 @@ let mockShareService = loadMojoModules(

]).then(mojo => {

let [bindings, webshare] = mojo.modules;

+ ShareError = webshare.ShareError;

class MockShareService {

constructor(interfaceProvider) {

this.bindingSet_ = new bindings.BindingSet(webshare.ShareService);