Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 2703313002: Expand FrameSeleciton::end() to increase chances of hoisting update layout (Closed)

Created:
3 years, 10 months ago by yosin_UTC9
Modified:
3 years, 10 months ago
Reviewers:
tkent, yoichio
CC:
blink-reviews, chromium-reviews, dcheng, dtapuska+blinkwatch_chromium.org, groby+blinkspell_chromium.org, kinuko+watch, mlamouri+watch-blink_chromium.org, Navid Zolghadr, timvolodine
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Expand FrameSeleciton::end() This patch expands |FrameSeleciton::end()| to increase chance of hoisting update layout. Note: This is mechanical change to replace |selection().end()| by |selection().computeVisibleSelectionInDOMTreeDeprecated().end()| Following patch will remove deprecated version. This patch is part of expanding expensive member functions in |FrameSelection|: - rootEditableElement() - hasEditableStyle() - isContentEditable() - isContentRichlyEditable() - base() - extent() - start() - end() - isNone() - isCaret() - isRange() BUG=694360 TEST=n/a; no behavior changes Review-Url: https://codereview.chromium.org/2703313002 Cr-Commit-Position: refs/heads/master@{#451743} Committed: https://chromium.googlesource.com/chromium/src/+/d4cacfa2ec6d6f41385b40f46af7ab385aba0921

Patch Set 1 : 2017-02-21T12:26:29 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -13 lines) Patch
M third_party/WebKit/Source/core/editing/FrameSelection.h View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/editing/InputMethodController.cpp View 1 chunk +5 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/InputMethodControllerTest.cpp View 2 chunks +10 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/input/EventHandlerTest.cpp View 2 chunks +6 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp View 1 chunk +4 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebLocalFrameImpl.cpp View 1 chunk +5 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebViewImpl.cpp View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 17 (11 generated)
yosin_UTC9
PTAL core/editing/, core/input/ and web/
3 years, 10 months ago (2017-02-21 04:49:37 UTC) #6
tkent
lgtm
3 years, 10 months ago (2017-02-21 05:11:12 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2703313002/1
3 years, 10 months ago (2017-02-21 05:23:02 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/122874)
3 years, 10 months ago (2017-02-21 08:24:57 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2703313002/1
3 years, 10 months ago (2017-02-21 12:29:33 UTC) #14
commit-bot: I haz the power
3 years, 10 months ago (2017-02-21 13:00:27 UTC) #17
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d4cacfa2ec6d6f41385b40f46af7...

Powered by Google App Engine
This is Rietveld 408576698