Issue 27033: Implement X509Certificate::Persist. This fixes gmail on linux.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 27033: Implement X509Certificate::Persist. This fixes gmail on linux. (Closed)

Created:
11 years, 10 months ago by dank

Modified:
9 years, 7 months ago

Reviewers:
darin (slow to review), Evan Martin

CC:
chromium-reviews_googlegroups.com

Base URL:
http://src.chromium.org/svn/trunk/src/

Visibility:
Public.

Description

Implement X509Certificate::Persist. This lets the browser read gmail on linux. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=10269

Patch Set 5 : '' #

Created: 11 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+32 lines, -15 lines)			Patch
	M	net/base/x509_certificate_nss.cc	View	1 2 3 4	10 chunks	+17 lines, -14 lines	0 comments	Download
	M	net/base/x509_certificate_unittest.cc	View	1 2 3 4	2 chunks	+15 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Evan Martin

rad! http://codereview.chromium.org/27033/diff/5/1006 File net/base/x509_certificate_nss.cc (right): http://codereview.chromium.org/27033/diff/5/1006#newcode192 Line 192: pickle->WriteBytes(cert_handle_->derCert.data, cert_handle_->derCert.len); Why not WriteData() to balance ...

11 years, 10 months ago (2009-02-21 05:40:21 UTC) #2

darin (slow to review)

11 years, 10 months ago (2009-02-22 17:34:54 UTC) #3

LGTM w/ these nits fixed:

http://codereview.chromium.org/27033/diff/1008/1010
File net/base/x509_certificate_nss.cc (right):

http://codereview.chromium.org/27033/diff/1008/1010#newcode191
Line 191: pickle->WriteData(reinterpret_cast<const char
*>(cert_handle_->derCert.data),
nit: no space before "*"

http://codereview.chromium.org/27033/diff/1008/1009
File net/base/x509_certificate_unittest.cc (right):

http://codereview.chromium.org/27033/diff/1008/1009#newcode6
Line 6: #include "base/port.h"
nit: the include of base/port.h is no longer necessary.  that comes from
base/basictypes.h which base/pickle.h includes.

Expand Messages | Collapse Messages

Issue 27033: Implement X509Certificate::Persist. This fixes gmail on linux. (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Messages