Chromium Code Reviews
Help | Chromium Project | Sign in
(2)

Issue 27033: Implement X509Certificate::Persist. This fixes gmail on linux. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years ago by dank
Modified:
5 years, 9 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Implement X509Certificate::Persist. This lets the browser read gmail on linux. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=10269

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 1

Patch Set 3 : '' #

Total comments: 2

Patch Set 4 : '' #

Patch Set 5 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -15 lines) Patch
M net/base/x509_certificate_nss.cc View 1 2 3 4 10 chunks +17 lines, -14 lines 0 comments Download
M net/base/x509_certificate_unittest.cc View 1 2 3 4 2 chunks +15 lines, -1 line 0 comments Download
Trybot results:
Commit queue not available (can’t edit this change).

Messages

Total messages: 3 (0 generated)
dank
Better late than never.
8 years ago (2009-02-21 04:51:31 UTC) #1
Evan Martin
rad! http://codereview.chromium.org/27033/diff/5/1006 File net/base/x509_certificate_nss.cc (right): http://codereview.chromium.org/27033/diff/5/1006#newcode192 Line 192: pickle->WriteBytes(cert_handle_->derCert.data, cert_handle_->derCert.len); Why not WriteData() to balance ...
8 years ago (2009-02-21 05:40:21 UTC) #2
darin (slow to review)
8 years ago (2009-02-22 17:34:54 UTC) #3
LGTM w/ these nits fixed:

http://codereview.chromium.org/27033/diff/1008/1010
File net/base/x509_certificate_nss.cc (right):

http://codereview.chromium.org/27033/diff/1008/1010#newcode191
Line 191: pickle->WriteData(reinterpret_cast<const char
*>(cert_handle_->derCert.data),
nit: no space before "*"

http://codereview.chromium.org/27033/diff/1008/1009
File net/base/x509_certificate_unittest.cc (right):

http://codereview.chromium.org/27033/diff/1008/1009#newcode6
Line 6: #include "base/port.h"
nit: the include of base/port.h is no longer necessary.  that comes from
base/basictypes.h which base/pickle.h includes.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f8e48bd