Gracefully handle navigator.getVRDisplays() in detached contexts.

Gracefully handle navigator.getVRDisplays() in detached contexts.

R=haraken
BUG=686602
Review-Url: https://codereview.chromium.org/2703283003
Cr-Commit-Position: refs/heads/master@{#451734}
Committed: https://chromium.googlesource.com/chromium/src/+/77af5df222bb276283d2c97fccbd91b32de286ce

[sof, 2017-02-21 08:23:22]

The CQ bit was checked by sigbjornf@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2017-02-21 08:23:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sof, 2017-02-21 08:24:37]

sigbjornf@opera.com changed reviewers:
+ haraken@chromium.org

[sof, 2017-02-21 08:24:37]

please take a look.

[haraken, 2017-02-21 09:50:23]

LGTM

[sof, 2017-02-21 09:54:05]

Description was changed from

==========
Gracefully handle navigator.getVRDisplays() in detached contexts.

R=
BUG=686602
==========

to

==========
Gracefully handle navigator.getVRDisplays() in detached contexts.

R=haraken
BUG=686602
==========

[commit-bot: I haz the power, 2017-02-21 11:14:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-21 11:14:05]

Dry run: This issue passed the CQ dry run.

[sof, 2017-02-21 11:34:18]

The CQ bit was checked by sigbjornf@opera.com

[commit-bot: I haz the power, 2017-02-21 11:34:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-21 11:39:00]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1487676858613450, "parent_rev":
"acc713786ac1643648471dd35083ce760dcdfd30", "commit_rev":
"77af5df222bb276283d2c97fccbd91b32de286ce"}

[commit-bot: I haz the power, 2017-02-21 11:39:31]

Description was changed from

==========
Gracefully handle navigator.getVRDisplays() in detached contexts.

R=haraken
BUG=686602
==========

to

==========
Gracefully handle navigator.getVRDisplays() in detached contexts.

R=haraken
BUG=686602

Review-Url: https://codereview.chromium.org/2703283003
Cr-Commit-Position: refs/heads/master@{#451734}
Committed:
https://chromium.googlesource.com/chromium/src/+/77af5df222bb276283d2c97fccbd...
==========

[commit-bot: I haz the power, 2017-02-21 11:39:32]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/77af5df222bb276283d2c97fccbd...

[mthiesse, 2017-02-21 15:19:26]

mthiesse@chromium.org changed reviewers:
+ mthiesse@chromium.org

[mthiesse, 2017-02-21 15:19:27]

https://codereview.chromium.org/2703283003/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/vr/NavigatorVR.cpp (right):

https://codereview.chromium.org/2703283003/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/vr/NavigatorVR.cpp:60: ScriptPromise promise =
resolver->promise();
nit: Why not remove this line, and return resolver->promise()?

[sof, 2017-02-21 15:29:12]

https://codereview.chromium.org/2703283003/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/vr/NavigatorVR.cpp (right):

https://codereview.chromium.org/2703283003/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/vr/NavigatorVR.cpp:60: ScriptPromise promise =
resolver->promise();
On 2017/02/21 15:19:27, mthiesse wrote:
> nit: Why not remove this line, and return resolver->promise()?

You have to call promise() before rejecting/resolving.