Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 2703253005: Support PermissionRequestManager for quota permissions on Android. (Closed)

Created:
3 years, 10 months ago by Timothy Loh
Modified:
3 years, 9 months ago
CC:
chrome-apps-syd-reviews_chromium.org, chromium-reviews, mlamouri+watch-permissions_chromium.org, raymes+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Support PermissionRequestManager for quota permissions on Android. This patch makes quota permission requests on Android go through the PermissionRequestManager when it is enabled. BUG=606138 Review-Url: https://codereview.chromium.org/2703253005 Cr-Commit-Position: refs/heads/master@{#455334} Committed: https://chromium.googlesource.com/chromium/src/+/5b34b672a205d81fc4cfa3b0b6c7ed5f98249c9a

Patch Set 1 #

Patch Set 2 : add a test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -17 lines) Patch
M chrome/android/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/android/java_sources.gni View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/permissions/PermissionTestCaseBase.java View 1 1 chunk +1 line, -0 lines 0 comments Download
A chrome/android/javatests/src/org/chromium/chrome/browser/permissions/QuotaTest.java View 1 1 chunk +43 lines, -0 lines 0 comments Download
M chrome/browser/chrome_quota_permission_context.cc View 3 chunks +19 lines, -17 lines 0 comments Download
A content/test/data/android/quota_permissions.html View 1 1 chunk +17 lines, -0 lines 0 comments Download

Messages

Total messages: 31 (22 generated)
Timothy Loh
3 years, 10 months ago (2017-02-21 06:06:21 UTC) #4
raymes
lgtm - are there any tests that need to be updated here?
3 years, 10 months ago (2017-02-22 01:36:58 UTC) #7
Timothy Loh
On 2017/02/22 01:36:58, raymes wrote: > lgtm - are there any tests that need to ...
3 years, 9 months ago (2017-03-06 03:07:34 UTC) #14
Timothy Loh
jochen@, could you review for OWNERs? Thanks!
3 years, 9 months ago (2017-03-06 03:26:25 UTC) #16
jochen (gone - plz use gerrit)
can you add a test please?
3 years, 9 months ago (2017-03-06 12:57:19 UTC) #19
Timothy Loh
On 2017/03/06 12:57:19, jochen wrote: > can you add a test please? Added a test. ...
3 years, 9 months ago (2017-03-07 03:29:12 UTC) #22
jochen (gone - plz use gerrit)
lgtm
3 years, 9 months ago (2017-03-07 11:50:42 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2703253005/20001
3 years, 9 months ago (2017-03-08 00:15:52 UTC) #28
commit-bot: I haz the power
3 years, 9 months ago (2017-03-08 01:50:53 UTC) #31
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/5b34b672a205d81fc4cfa3b0b6c7...

Powered by Google App Engine
This is Rietveld 408576698