devtools: Make it possible to override the navigation referrer

devtools: Make it possible to override the navigation referrer

This patch adds an optional 'referrer' parameter to the Page.navigate
command, letting the client override the referrer for a navigation.

BUG=546953
Review-Url: https://codereview.chromium.org/2703253002
Cr-Commit-Position: refs/heads/master@{#452110}
Committed: https://chromium.googlesource.com/chromium/src/+/c5851e79ac5602616d6b28267e217d169804a3f2

[Sami, 2017-02-20 17:30:00]

The CQ bit was checked by skyostil@chromium.org to run a CQ dry run

[Sami, 2017-02-20 17:30:09]

Description was changed from

==========
devtools: Make it possible to override the navigation referrer

This patch adds an optional 'referrer' parameter to the Page.navigate
command, letting the client override the referrer for a navigation.

BUG=546953
==========

to

==========
devtools: Make it possible to override the navigation referrer

This patch adds an optional 'referrer' parameter to the Page.navigate
command, letting the client override the referrer for a navigation.

BUG=546953
==========

[Sami, 2017-02-20 17:30:10]

skyostil@chromium.org changed reviewers:
+ dgozman@chromium.org

[commit-bot: I haz the power, 2017-02-20 17:30:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-20 19:16:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-20 19:17:00]

Dry run: This issue passed the CQ dry run.

[pfeldman, 2017-02-21 18:47:30]

pfeldman@chromium.org changed reviewers:
+ pfeldman@chromium.org

[pfeldman, 2017-02-21 18:47:31]

The code looks good, but you could use the inspector-protocol harness to make
the test simpler.

https://codereview.chromium.org/2703253002/diff/1/content/browser/devtools/pr...
File content/browser/devtools/protocol/devtools_protocol_browsertest.cc (right):

https://codereview.chromium.org/2703253002/diff/1/content/browser/devtools/pr...
content/browser/devtools/protocol/devtools_protocol_browsertest.cc:1655:
ASSERT_TRUE(embedded_test_server()->Start());
Why not inspector protocol test?

[pfeldman, 2017-02-21 18:48:51]

(provisional lgtm for the code itself)

[dgozman, 2017-02-21 18:51:51]

lgtm

[Sami, 2017-02-22 16:01:58]

https://codereview.chromium.org/2703253002/diff/1/content/browser/devtools/pr...
File content/browser/devtools/protocol/devtools_protocol_browsertest.cc (right):

https://codereview.chromium.org/2703253002/diff/1/content/browser/devtools/pr...
content/browser/devtools/protocol/devtools_protocol_browsertest.cc:1655:
ASSERT_TRUE(embedded_test_server()->Start());
On 2017/02/21 18:47:30, pfeldman wrote:
> Why not inspector protocol test?

Done. (Although it ended up being a little involved because of how navigations
work in the protocol tests.)

[Sami, 2017-02-22 16:02:10]

The CQ bit was checked by skyostil@chromium.org

[Sami, 2017-02-22 16:02:10]

The patchset sent to the CQ was uploaded after l-g-t-m from
dgozman@chromium.org, pfeldman@chromium.org
Link to the patchset: https://codereview.chromium.org/2703253002/#ps20001
(title: "Reworked into a inspector protocol test")

[commit-bot: I haz the power, 2017-02-22 16:03:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-22 17:36:37]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1487779330586960,
"parent_rev": "6ba8baa98a274d2bb9aef1d95bdb237255f09ba8", "commit_rev":
"c5851e79ac5602616d6b28267e217d169804a3f2"}

[commit-bot: I haz the power, 2017-02-22 17:37:22]

Description was changed from

==========
devtools: Make it possible to override the navigation referrer

This patch adds an optional 'referrer' parameter to the Page.navigate
command, letting the client override the referrer for a navigation.

BUG=546953
==========

to

==========
devtools: Make it possible to override the navigation referrer

This patch adds an optional 'referrer' parameter to the Page.navigate
command, letting the client override the referrer for a navigation.

BUG=546953

Review-Url: https://codereview.chromium.org/2703253002
Cr-Commit-Position: refs/heads/master@{#452110}
Committed:
https://chromium.googlesource.com/chromium/src/+/c5851e79ac5602616d6b28267e21...
==========

[commit-bot: I haz the power, 2017-02-22 17:37:23]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/c5851e79ac5602616d6b28267e21...