Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(881)

Issue 2703243002: [wasm] Move decoding constants out of wasm-module.h and into module-decoder.h (Closed)

Created:
3 years, 10 months ago by titzer
Modified:
3 years, 10 months ago
Reviewers:
Clemens Hammacher
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Move decoding constants out of wasm-module.h and into module-decoder.h R=clemensh@chromium.org BUG= Review-Url: https://codereview.chromium.org/2703243002 Cr-Commit-Position: refs/heads/master@{#43332} Committed: https://chromium.googlesource.com/v8/v8/+/7f672535e68fe103d4e9e0192adecc6b47e7c0b5

Patch Set 1 #

Patch Set 2 : Fix fuzzer #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -68 lines) Patch
M src/wasm/module-decoder.h View 1 chunk +29 lines, -0 lines 0 comments Download
M src/wasm/module-decoder.cc View 1 chunk +33 lines, -0 lines 0 comments Download
M src/wasm/wasm-module.h View 1 chunk +0 lines, -34 lines 0 comments Download
M src/wasm/wasm-module.cc View 1 1 chunk +0 lines, -33 lines 0 comments Download
M src/wasm/wasm-module-builder.cc View 1 chunk +1 line, -0 lines 0 comments Download
M test/fuzzer/wasm-section-fuzzers.h View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (11 generated)
titzer
3 years, 10 months ago (2017-02-20 15:56:34 UTC) #1
Clemens Hammacher
lgtm
3 years, 10 months ago (2017-02-20 17:31:14 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2703243002/20001
3 years, 10 months ago (2017-02-20 17:40:45 UTC) #12
commit-bot: I haz the power
3 years, 10 months ago (2017-02-20 17:42:13 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/7f672535e68fe103d4e9e0192adecc6b47e...

Powered by Google App Engine
This is Rietveld 408576698