Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Issue 2703233002: 📰 Use "> 320dp" instead of ">= 360dp" for regular layouts (Closed)

Created:
3 years, 10 months ago by dgn
Modified:
3 years, 10 months ago
Reviewers:
Bernhard Bauer
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

📰 Use "> 320dp" instead of ">= 360dp" for regular layouts Change the way the UiConfig thesholds are defined so that the switch to small layouts is more restricted. The status bar height is substracted from the screen height, which makes 360dp wide devices like Pixel fall under the FLAT bucket when in landscape. BUG=None Review-Url: https://codereview.chromium.org/2703233002 Cr-Commit-Position: refs/heads/master@{#451624} Committed: https://chromium.googlesource.com/chromium/src/+/18c783a47701f4ddc8756f3df1c49ca747f3dc87

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -6 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/widget/displaystyle/UiConfig.java View 3 chunks +5 lines, -6 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
dgn
PTAL
3 years, 10 months ago (2017-02-20 13:24:00 UTC) #2
Bernhard Bauer
lgtm
3 years, 10 months ago (2017-02-20 14:18:14 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2703233002/1
3 years, 10 months ago (2017-02-20 14:20:19 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-02-20 14:27:29 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/18c783a47701f4ddc8756f3df1c4...

Powered by Google App Engine
This is Rietveld 408576698