Migrate extension notifications to the new NotificationDisplayService

chrome/browser/extensions/api/notifications/notifications_api.h

Index: chrome/browser/extensions/api/notifications/notifications_api.h
diff --git a/chrome/browser/extensions/api/notifications/notifications_api.h b/chrome/browser/extensions/api/notifications/notifications_api.h
index d7bb4b712c7d7e59fb6f9af9192c560a3d711baf..1a21c1189656b464fc497bba6527de6f86067e90 100644
--- a/chrome/browser/extensions/api/notifications/notifications_api.h
+++ b/chrome/browser/extensions/api/notifications/notifications_api.h
@@ -20,6 +20,8 @@ namespace extensions {
 
 extern const base::Feature kAllowFullscreenAppNotificationsFeature;
 
+class ExtensionNotificationDisplayHelper;
+
 class NotificationsApiFunction : public ChromeAsyncExtensionFunction {

[Miguel Garcia, 2017/02/21 10:56:43]

Can you describe briefly (perhaps offline) the ownership model of this thing?

[Peter Beverloo, 2017/02/21 17:23:50]

The functions will be created on demand by the ExtensionFunctionDispatcher.
There their instance remains reference counted until its execution has been
completed.

(Only Extension API functions implemented in JavaScript can return values, all
the other ones take callback parameters so that their execution can be entirely
asynchronous.)

  public:
   // Whether the current extension and channel allow the API. Public for
@@ -40,6 +42,10 @@ class NotificationsApiFunction : public ChromeAsyncExtensionFunction {
 
   bool AreExtensionNotificationsAllowed() const;
 
+  // Returns the display helper that should be used for interacting with the
+  // common notification system.
+  ExtensionNotificationDisplayHelper* GetDisplayHelper() const;
+
   // Returns true if the API function is still allowed to run even when the
   // notifications for a notifier have been disabled.
   virtual bool CanRunWhileDisabled() const;