Migrate extension notifications to the new NotificationDisplayService

chrome/browser/extensions/api/notifications/notifications_api.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_EXTENSIONS_API_NOTIFICATIONS_NOTIFICATIONS_API_H_
 #define CHROME_BROWSER_EXTENSIONS_API_NOTIFICATIONS_NOTIFICATIONS_API_H_
 
 #include <string>
 
 #include "base/feature_list.h"
 #include "base/memory/ref_counted.h"
 #include "chrome/browser/extensions/chrome_extension_function.h"
 #include "chrome/common/extensions/api/notifications.h"
 #include "extensions/browser/extension_function.h"
 #include "ui/message_center/notification_types.h"
 
 class Notification;
 
 namespace extensions {
 
 extern const base::Feature kAllowFullscreenAppNotificationsFeature;
 
+class ExtensionNotificationDisplayHelper;
+
 class NotificationsApiFunction : public ChromeAsyncExtensionFunction {

[Miguel Garcia, 2017/02/21 10:56:43]

Can you describe briefly (perhaps offline) the ownership model of this thing?

[Peter Beverloo, 2017/02/21 17:23:50]

The functions will be created on demand by the ExtensionFunctionDispatcher.
There their instance remains reference counted until its execution has been
completed.

(Only Extension API functions implemented in JavaScript can return values, all
the other ones take callback parameters so that their execution can be entirely
asynchronous.)

  public:
   // Whether the current extension and channel allow the API. Public for
   // testing.
   bool IsNotificationsApiAvailable();
 
  protected:
   NotificationsApiFunction();
   ~NotificationsApiFunction() override;
 
   bool CreateNotification(const std::string& id,
                           api::notifications::NotificationOptions* options);
   bool UpdateNotification(const std::string& id,
                           api::notifications::NotificationOptions* options,
                           Notification* notification);
 
   bool IsNotificationsApiEnabled() const;
 
   bool AreExtensionNotificationsAllowed() const;
 
+  // Returns the display helper that should be used for interacting with the
+  // common notification system.
+  ExtensionNotificationDisplayHelper* GetDisplayHelper() const;
+
   // Returns true if the API function is still allowed to run even when the
   // notifications for a notifier have been disabled.
   virtual bool CanRunWhileDisabled() const;
 
   // Called inside of RunAsync.
   virtual bool RunNotificationsApi() = 0;
 
   // UITHreadExtensionFunction:
   bool RunAsync() override;
 
@@ skipping 76 matching lines @@
   ~NotificationsGetPermissionLevelFunction() override;
 
  private:
   DECLARE_EXTENSION_FUNCTION("notifications.getPermissionLevel",
                              NOTIFICATIONS_GET_ALL)
 };
 
 }  // namespace extensions
 
 #endif  // CHROME_BROWSER_EXTENSIONS_API_NOTIFICATIONS_NOTIFICATIONS_API_H_