Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Issue 2703213003: Revert "Improve the resolution of the menu item homescreen launch source metric." (Closed)

Created:
3 years, 10 months ago by dominickn
Modified:
3 years, 10 months ago
Reviewers:
CC:
chromium-reviews, dominickn+watch_chromium.org, pkotwicz+watch_chromium.org, zpeng+watch_chromium.org, asvitkine+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

Revert "Improve the resolution of the menu item homescreen launch source metric." This reverts commit 3feb5fba279ded7c74309592bc573063de5fd28f. Reason for revert: breaks M57 compile because this smuggles an unrelated change from tip of tree onto M57 (which doesn't support it). BUG=690266 Review-Url: https://codereview.chromium.org/2703213003 . Cr-Commit-Position: refs/branch-heads/2987@{#596} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/f53b2a806f534f4195fc6873b1185aa456b1fd06

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -89 lines) Patch
M chrome/browser/android/metrics/launch_metrics.cc View 2 chunks +14 lines, -42 lines 0 comments Download
M chrome/browser/android/shortcut_info.h View 1 chunk +2 lines, -5 lines 0 comments Download
M chrome/browser/android/shortcut_info.cc View 2 chunks +6 lines, -9 lines 0 comments Download
M chrome/browser/android/webapps/add_to_homescreen_data_fetcher.cc View 3 chunks +3 lines, -14 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 2 chunks +1 line, -19 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
dominickn
3 years, 10 months ago (2017-02-20 10:29:36 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
f53b2a806f534f4195fc6873b1185aa456b1fd06.

Powered by Google App Engine
This is Rietveld 408576698