ServiceWorker: ignore AddMessageToConsole before process allocation

content/browser/service_worker/embedded_worker_instance.cc

Index: content/browser/service_worker/embedded_worker_instance.cc
diff --git a/content/browser/service_worker/embedded_worker_instance.cc b/content/browser/service_worker/embedded_worker_instance.cc
index 4aed03ff82a51cd65a2e7578bda5e9b24fe9a98b..78c68563c696f612e64992892f5a512bedf3673b 100644
--- a/content/browser/service_worker/embedded_worker_instance.cc
+++ b/content/browser/service_worker/embedded_worker_instance.cc
@@ -871,9 +871,17 @@ base::TimeDelta EmbeddedWorkerInstance::UpdateStepTime() {
 void EmbeddedWorkerInstance::AddMessageToConsole(
     blink::WebConsoleMessage::Level level,
     const std::string& message) {
-  if (status_ != EmbeddedWorkerStatus::RUNNING &&
-      status_ != EmbeddedWorkerStatus::STARTING) {
-    return;
+  // Return if EmbeddedWorkerInstance does not have a valid process.
+  switch (status()) {
+    case EmbeddedWorkerStatus::STOPPING:
+    case EmbeddedWorkerStatus::STOPPED:
+      return;
+    case EmbeddedWorkerStatus::STARTING:
+      if (!HasSentStartWorker(starting_phase()))
+        return;
+      break;
+    case EmbeddedWorkerStatus::RUNNING:
+      break;

[falken, 2017/02/21 04:03:30]

Sorry for keeping suggesting things. Would if (process_id() != kInvalidUniqueID)
work also? It just seems like a tricky piece of code to put in
AddMessageToConsole. Or should we just refactor it to a function HasProcess()?
It's somewhat surprising this is the only place the check is needed...

[shimazu, 2017/02/21 04:39:51]

process_id() != kInvalidUniqueID seems much better than current if/switch.
Updated, thanks!

   }
   DCHECK(client_.is_bound());
   client_->AddMessageToConsole(level, message);