ServiceWorker: ignore AddMessageToConsole before process allocation

content/browser/service_worker/embedded_worker_instance.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/service_worker/embedded_worker_instance.h"
 
 #include <utility>
 
 #include "base/bind_helpers.h"
 #include "base/macros.h"
@@ skipping 853 matching lines @@
   DCHECK(!step_time_.is_null());
   base::TimeTicks now = base::TimeTicks::Now();
   base::TimeDelta duration = now - step_time_;
   step_time_ = now;
   return duration;
 }
 
 void EmbeddedWorkerInstance::AddMessageToConsole(
     blink::WebConsoleMessage::Level level,
     const std::string& message) {
-  if (status_ != EmbeddedWorkerStatus::RUNNING &&
-      status_ != EmbeddedWorkerStatus::STARTING) {
-    return;
+  // Return if EmbeddedWorkerInstance does not have a valid process.
+  switch (status()) {
+    case EmbeddedWorkerStatus::STOPPING:
+    case EmbeddedWorkerStatus::STOPPED:
+      return;
+    case EmbeddedWorkerStatus::STARTING:
+      if (!HasSentStartWorker(starting_phase()))
+        return;
+      break;
+    case EmbeddedWorkerStatus::RUNNING:
+      break;

[falken, 2017/02/21 04:03:30]

Sorry for keeping suggesting things. Would if (process_id() != kInvalidUniqueID)
work also? It just seems like a tricky piece of code to put in
AddMessageToConsole. Or should we just refactor it to a function HasProcess()?
It's somewhat surprising this is the only place the check is needed...

[shimazu, 2017/02/21 04:39:51]

process_id() != kInvalidUniqueID seems much better than current if/switch.
Updated, thanks!

   }
   DCHECK(client_.is_bound());
   client_->AddMessageToConsole(level, message);
 }
 
 // static
 std::string EmbeddedWorkerInstance::StatusToString(
     EmbeddedWorkerStatus status) {
   switch (status) {
     case EmbeddedWorkerStatus::STOPPED:
@@ skipping 33 matching lines @@
     case SCRIPT_READ_FINISHED:
       return "Script read finished";
     case STARTING_PHASE_MAX_VALUE:
       NOTREACHED();
   }
   NOTREACHED() << phase;
   return std::string();
 }
 
 }  // namespace content