ServiceWorker: ignore AddMessageToConsole before process allocation

content/browser/service_worker/embedded_worker_instance.cc

Index: content/browser/service_worker/embedded_worker_instance.cc
diff --git a/content/browser/service_worker/embedded_worker_instance.cc b/content/browser/service_worker/embedded_worker_instance.cc
index 4aed03ff82a51cd65a2e7578bda5e9b24fe9a98b..6908f83fe432d91a0826b19db2430b32c2814868 100644
--- a/content/browser/service_worker/embedded_worker_instance.cc
+++ b/content/browser/service_worker/embedded_worker_instance.cc
@@ -871,8 +871,11 @@ base::TimeDelta EmbeddedWorkerInstance::UpdateStepTime() {
 void EmbeddedWorkerInstance::AddMessageToConsole(
     blink::WebConsoleMessage::Level level,
     const std::string& message) {
-  if (status_ != EmbeddedWorkerStatus::RUNNING &&
-      status_ != EmbeddedWorkerStatus::STARTING) {
+  // Return if EmbeddedWorkerInstance does not have a valid process.
+  if (status() == EmbeddedWorkerStatus::STOPPING ||
+      status() == EmbeddedWorkerStatus::STOPPED ||
+      (status() == EmbeddedWorkerStatus::STARTING &&
+       !HasSentStartWorker(starting_phase()))) {

[falken, 2017/02/20 08:01:03]

can we turn this into a switch statement?

[falken, 2017/02/20 08:14:45]

On second thought, would it be better to just do (!client_.is_bound) { return;
}?

With a comment that this function can be called when the worker is not running?

[shimazu, 2017/02/21 03:13:53]

|client_| is valid just after calling Start(), so it's not enough in this case.
Yes, this function can be called while starting (e.g. script loading).

[shimazu, 2017/02/21 03:13:53]

Done.

     return;
   }
   DCHECK(client_.is_bound());