ServiceWorker: ignore AddMessageToConsole before process allocation

content/browser/service_worker/embedded_worker_instance.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/service_worker/embedded_worker_instance.h"
 
 #include <utility>
 
 #include "base/bind_helpers.h"
 #include "base/macros.h"
@@ skipping 853 matching lines @@
   DCHECK(!step_time_.is_null());
   base::TimeTicks now = base::TimeTicks::Now();
   base::TimeDelta duration = now - step_time_;
   step_time_ = now;
   return duration;
 }
 
 void EmbeddedWorkerInstance::AddMessageToConsole(
     blink::WebConsoleMessage::Level level,
     const std::string& message) {
-  if (status_ != EmbeddedWorkerStatus::RUNNING &&
-      status_ != EmbeddedWorkerStatus::STARTING) {
+  // Return if EmbeddedWorkerInstance does not have a valid process.
+  if (status() == EmbeddedWorkerStatus::STOPPING ||
+      status() == EmbeddedWorkerStatus::STOPPED ||
+      (status() == EmbeddedWorkerStatus::STARTING &&
+       !HasSentStartWorker(starting_phase()))) {

[falken, 2017/02/20 08:01:03]

can we turn this into a switch statement?

[falken, 2017/02/20 08:14:45]

On second thought, would it be better to just do (!client_.is_bound) { return;
}?

With a comment that this function can be called when the worker is not running?

[shimazu, 2017/02/21 03:13:53]

|client_| is valid just after calling Start(), so it's not enough in this case.
Yes, this function can be called while starting (e.g. script loading).

[shimazu, 2017/02/21 03:13:53]

Done.

     return;
   }
   DCHECK(client_.is_bound());
   client_->AddMessageToConsole(level, message);
 }
 
 // static
 std::string EmbeddedWorkerInstance::StatusToString(
     EmbeddedWorkerStatus status) {
   switch (status) {
@@ skipping 34 matching lines @@
     case SCRIPT_READ_FINISHED:
       return "Script read finished";
     case STARTING_PHASE_MAX_VALUE:
       NOTREACHED();
   }
   NOTREACHED() << phase;
   return std::string();
 }
 
 }  // namespace content