third_party/WebKit/Source/devtools/front_end/profiler/HeapSnapshotView.js - Issue 2703143002: [DevTools] Prepare to move Popover to shadow DOM.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/profiler/HeapSnapshotView.js

Issue 2703143002: [DevTools] Prepare to move Popover to shadow DOM. (Closed)

Patch Set: Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/inspector/tracing/timeline-network/timeline-network-resource-details.html ('K') | « third_party/WebKit/Source/devtools/front_end/network/networkTimingTable.css ('k') | third_party/WebKit/Source/devtools/front_end/source_frame/UISourceCodeFrame.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/profiler/HeapSnapshotView.js

diff --git a/third_party/WebKit/Source/devtools/front_end/profiler/HeapSnapshotView.js b/third_party/WebKit/Source/devtools/front_end/profiler/HeapSnapshotView.js

index 9356502e5f66b52a42aee4542d796d45dd5e70a9..297f2bf9ba21f9570ffe325b9b3f8801847099d0 100644

--- a/third_party/WebKit/Source/devtools/front_end/profiler/HeapSnapshotView.js

+++ b/third_party/WebKit/Source/devtools/front_end/profiler/HeapSnapshotView.js

@@ -260,8 +260,6 @@ Profiler.HeapSnapshotView = class extends UI.SimpleView {

willHide() {

this._currentSearchResultIndex = -1;

this._popoverHelper.hidePopover();

- if (this.helpPopover && this.helpPopover.isShowing())

- this.helpPopover.hide();

}

/**