Close receive port on error to avoid hanging forever

Close receive port on error to avoid hanging forever

Closes https://github.com/dart-lang/sdk/issues/28789

R=kmillikin@google.com

Committed: https://github.com/dart-lang/sdk/commit/5cd765ba4dc8b8c0a1f2f185aa95d6e56c98c624

[jensj, 2017-02-21 08:02:54]

Description was changed from

==========
Close receive port on error to avoid hanging forever

https://github.com/dart-lang/sdk/issues/28789

BUG=
==========

to

==========
Close receive port on error to avoid hanging forever

Closes https://github.com/dart-lang/sdk/issues/28789
==========

[jensj, 2017-02-21 08:02:54]

jensj@google.com changed reviewers:
+ kmillikin@google.com

[jensj, 2017-02-21 08:08:49]

For completeness I will summarize the problem here (see issue for more details):

When debugging kernel via with kernel isolate the VM sometimes doesn't shut
down. It hangs in
```
#2  0x00000000009398fa dart::ServiceIsolate::Shutdown()
#3  0x00000000006baa36 dart::Dart::Cleanup()
```

It seems to be caused by a ReceivePort being opened, erroring out because a
message cannot be send and it then not being closed.

While I only saw this when running via the kernel isolate it doesn't appear to
have anything to do with that. It probably only alters the timing in favor of
this happening.

[Kevin Millikin (Google), 2017-02-21 09:55:02]

lgtm

[jensj, 2017-02-21 10:05:57]

Description was changed from

==========
Close receive port on error to avoid hanging forever

Closes https://github.com/dart-lang/sdk/issues/28789
==========

to

==========
Close receive port on error to avoid hanging forever

Closes https://github.com/dart-lang/sdk/issues/28789

R=kmillikin@google.com

Committed:
https://github.com/dart-lang/sdk/commit/5cd765ba4dc8b8c0a1f2f185aa95d6e56c98c624
==========

[jensj, 2017-02-21 10:05:59]

Committed patchset #1 (id:1) manually as
5cd765ba4dc8b8c0a1f2f185aa95d6e56c98c624 (presubmit successful).