sdk/lib/vmservice/message.dart - Issue 2703133004: Close receive port on error to avoid hanging forever

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/vmservice/message.dart

Issue 2703133004: Close receive port on error to avoid hanging forever (Closed)

Patch Set: Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sdk/lib/vmservice/message.dart

diff --git a/sdk/lib/vmservice/message.dart b/sdk/lib/vmservice/message.dart

index 0c021715a3f2ec1d376a9e049f55d160f964c2ee..cbce8c2c11831885b5a36de9f29c5a512c2ab311 100644

--- a/sdk/lib/vmservice/message.dart

+++ b/sdk/lib/vmservice/message.dart

@@ -109,6 +109,7 @@ class Message {

..[4] = keys

..[5] = values;

if (!sendIsolateServiceMessage(sendPort, request)) {

+ receivePort.close();

_completer.complete(JSON.encode({

'type': 'ServiceError',

'id': '',

« no previous file with comments | « no previous file | no next file » | no next file with comments »