Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 2703133003: [turbofan] Unify NodeProperties::InferReceiverMaps. (Closed)

Created:
3 years, 10 months ago by Benedikt Meurer
Modified:
3 years, 10 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Unify NodeProperties::InferReceiverMaps. Unify the three different implementations of InferReceiverMaps, which were basically copy&paste with slightly different optimizations applied later into a single NodeProperties::InferReceiverMaps helper, which also returns a ZoneHandleSet of maps, rather than only a single map. BUG=v8:5267 R=jarin@chromium.org Review-Url: https://codereview.chromium.org/2703133003 Cr-Commit-Position: refs/heads/master@{#43318} Committed: https://chromium.googlesource.com/v8/v8/+/fc3312255f44eefac0677a9c0267095858c7c799

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+141 lines, -150 lines) Patch
M src/compiler/js-builtin-reducer.cc View 1 chunk +4 lines, -17 lines 0 comments Download
M src/compiler/js-call-reducer.cc View 2 chunks +18 lines, -34 lines 0 comments Download
M src/compiler/js-inlining.cc View 1 chunk +9 lines, -34 lines 0 comments Download
M src/compiler/js-native-context-specialization.h View 1 chunk +6 lines, -4 lines 0 comments Download
M src/compiler/js-native-context-specialization.cc View 2 chunks +11 lines, -61 lines 0 comments Download
M src/compiler/node-properties.h View 2 chunks +7 lines, -0 lines 0 comments Download
M src/compiler/node-properties.cc View 2 chunks +86 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Benedikt Meurer
3 years, 10 months ago (2017-02-20 12:08:34 UTC) #1
Benedikt Meurer
Hey Jaro, Unifying the various ways to find receiver maps from the graph. Please take ...
3 years, 10 months ago (2017-02-20 12:13:15 UTC) #4
Jarin
lgtm
3 years, 10 months ago (2017-02-20 12:16:22 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2703133003/1
3 years, 10 months ago (2017-02-20 12:24:18 UTC) #8
commit-bot: I haz the power
3 years, 10 months ago (2017-02-20 12:54:10 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/fc3312255f44eefac0677a9c0267095858c...

Powered by Google App Engine
This is Rietveld 408576698