Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Issue 2703113003: [compiler] Cleanup: Move DCHECK into ChangeToPureOp. (Closed)

Created:
3 years, 10 months ago by neis
Modified:
3 years, 10 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[compiler] Cleanup: Move DCHECK into ChangeToPureOp. R=jarin@chromium.org BUG= Review-Url: https://codereview.chromium.org/2703113003 Cr-Commit-Position: refs/heads/master@{#43339} Committed: https://chromium.googlesource.com/v8/v8/+/99d618193a23a5fbe7f3901f6d909ff776ef8fcf

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/compiler/simplified-lowering.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
neis
3 years, 10 months ago (2017-02-20 16:04:46 UTC) #1
Jarin
lgtm
3 years, 10 months ago (2017-02-21 09:20:28 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2703113003/1
3 years, 10 months ago (2017-02-21 09:22:27 UTC) #4
commit-bot: I haz the power
3 years, 10 months ago (2017-02-21 09:46:25 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/99d618193a23a5fbe7f3901f6d909ff776e...

Powered by Google App Engine
This is Rietveld 408576698