Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(333)

Unified Diff: ios/chrome/browser/favicon/ios_chrome_large_icon_service_factory.cc

Issue 2703003002: Set null testing Favicon factories on iOS too (Closed)
Patch Set: Revert traces. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/favicon/ios_chrome_large_icon_service_factory.cc
diff --git a/ios/chrome/browser/favicon/ios_chrome_large_icon_service_factory.cc b/ios/chrome/browser/favicon/ios_chrome_large_icon_service_factory.cc
index 1125c07da7be756318836eb18c28617118983589..5d01fb2c2fd665845f459159dc76b5b57852f3f8 100644
--- a/ios/chrome/browser/favicon/ios_chrome_large_icon_service_factory.cc
+++ b/ios/chrome/browser/favicon/ios_chrome_large_icon_service_factory.cc
@@ -32,7 +32,9 @@ IOSChromeLargeIconServiceFactory::GetInstance() {
IOSChromeLargeIconServiceFactory::IOSChromeLargeIconServiceFactory()
: BrowserStateKeyedServiceFactory(
"LargeIconService",
- BrowserStateDependencyManager::GetInstance()) {}
+ BrowserStateDependencyManager::GetInstance()) {
+ DependsOn(ios::FaviconServiceFactory::GetInstance());
+}
IOSChromeLargeIconServiceFactory::~IOSChromeLargeIconServiceFactory() {}
@@ -52,3 +54,7 @@ web::BrowserState* IOSChromeLargeIconServiceFactory::GetBrowserStateToUse(
web::BrowserState* context) const {
return GetBrowserStateOwnInstanceInIncognito(context);
}
+
+bool IOSChromeLargeIconServiceFactory::ServiceIsNULLWhileTesting() const {
+ return true;
+}

Powered by Google App Engine
This is Rietveld 408576698