Source/core/html/HTMLOptionElement.cpp - Issue 27030014: Remove Backslash-as-JPY hack

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLOptionElement.cpp

Issue 27030014: Remove Backslash-as-JPY hack (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: TextCodec/Encoding added Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/html/HTMLOptionElement.cpp

diff --git a/Source/core/html/HTMLOptionElement.cpp b/Source/core/html/HTMLOptionElement.cpp

index dbe4d00c1484d4c4bbfa5855a156135888e0b088..85dffe1e993a33ce1dcfedb8d1253e4b9abd6248 100644

--- a/Source/core/html/HTMLOptionElement.cpp

+++ b/Source/core/html/HTMLOptionElement.cpp

@@ -123,9 +123,7 @@ String HTMLOptionElement::text() const

if (text.isEmpty())

text = collectOptionInnerText();

- // FIXME: Is displayStringModifiedByEncoding helpful here?

- // If it's correct here, then isn't it needed in the value and label functions too?

- return document.displayStringModifiedByEncoding(text).stripWhiteSpace(isHTMLSpace<UChar>).simplifyWhiteSpace(isHTMLSpace<UChar>);

+ return text.stripWhiteSpace(isHTMLSpace<UChar>).simplifyWhiteSpace(isHTMLSpace<UChar>);

}

void HTMLOptionElement::setText(const String &text, ExceptionState& es)

« no previous file with comments | « Source/core/html/HTMLOptGroupElement.cpp ('k') | Source/core/page/Chrome.cpp » ('j') | no next file with comments »