Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(323)

Issue 27029004: Increasing click target size to deflake ImeTests. (Closed)

Created:
7 years, 2 months ago by aurimas (slooooooooow)
Modified:
7 years, 2 months ago
Reviewers:
Yaron
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Increasing click target size to deflake ImeTests. Blink CL change the font scale https://codereview.chromium.org/26272006 and that caused ImeTest#testEnterTextAndRefocus failures because DOMUtils.clickNode(...) somehow misses the click target. Increasing the size of the radio button will fix that failure. NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=228230

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
aurimas (slooooooooow)
Hey Yaron, Please take a look at this 1 line CL. Thanks! Aurimas
7 years, 2 months ago (2013-10-11 16:26:46 UTC) #1
Yaron
lgtm but it sounds like this requires some follow up. Can you file a bug ...
7 years, 2 months ago (2013-10-11 17:04:01 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aurimas@chromium.org/27029004/1
7 years, 2 months ago (2013-10-11 18:25:51 UTC) #3
commit-bot: I haz the power
7 years, 2 months ago (2013-10-11 19:44:50 UTC) #4
Message was sent while issue was closed.
Change committed as 228230

Powered by Google App Engine
This is Rietveld 408576698