Issue 26272006: Fix Skia FontCache platform data construction to use right font size

Issue 26272006: Fix Skia FontCache platform data construction to use right font size (Closed)

Created:
7 years, 2 months ago by eae

Modified:
7 years, 2 months ago

Reviewers:
leviw_travelin_and_unemployed

CC:
blink-reviews, jamesr, dsinclair, danakj, Rik, Stephen Chennney, pdr.

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Fix Skia FontCache platform data construction to use right font size The skia version of FontCache::createFontPlatformData incorrectly used fontDescription.computedSize instead of computedPixelSize even if sub- pixel font scaling wasn't enabled. This could cause an entry with the wrong size to be added to the FontCache. BUG=304986 R=leviw@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=159122

Patch Set 1 #

Patch Set 2 : Patch for landing #

Patch Set 3 : #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+33 lines, -8 lines)			Patch
M	LayoutTests/TestExpectations	View	1 2	2 chunks	+25 lines, -3 lines	0 comments	Download
M	LayoutTests/css3/zoom-coords.xhtml	View	1 2	2 chunks	+2 lines, -2 lines	0 comments	Download
M	LayoutTests/platform/linux/css3/zoom-coords-expected.txt	View	1 2	2 chunks	+2 lines, -2 lines	0 comments	Download
M	LayoutTests/platform/linux/fast/forms/placeholder-position-expected.png	View		Binary file		0 comments	Download
M	Source/core/platform/graphics/skia/FontCacheSkia.cpp	View	1	2 chunks	+4 lines, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eae@chromium.org/26272006/6001

7 years, 2 months ago (2013-10-08 01:15:22 UTC) #3

commit-bot: I haz the power

Retried try job too often on linux_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blink_rel&number=7146

7 years, 2 months ago (2013-10-08 02:39:37 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eae@chromium.org/26272006/21001

7 years, 2 months ago (2013-10-08 15:29:09 UTC) #5

Message was sent while issue was closed.

Change committed as 159122

Expand Messages | Collapse Messages