Work around one more callsite into PaintLayerClipper

third_party/WebKit/Source/core/paint/PaintLayerClipper.cpp

Index: third_party/WebKit/Source/core/paint/PaintLayerClipper.cpp
diff --git a/third_party/WebKit/Source/core/paint/PaintLayerClipper.cpp b/third_party/WebKit/Source/core/paint/PaintLayerClipper.cpp
index 44474e5be734767a26b67bda27c7b6d2c520d930..d1d890aa1507419d466f6eb6422bf1ef3596cb80 100644
--- a/third_party/WebKit/Source/core/paint/PaintLayerClipper.cpp
+++ b/third_party/WebKit/Source/core/paint/PaintLayerClipper.cpp
@@ -510,6 +510,10 @@ void PaintLayerClipper::applyOverflowClipToBackgroundRectWithGeometryMapper(
 ClipRect PaintLayerClipper::backgroundClipRect(
     const ClipRectsContext& context) const {
   if (m_geometryMapper) {
+    // TODO(chrishtr): fix the underlying bug that causes this situation.
+    if (!m_layer.layoutObject()->paintProperties())
+      return ClipRect(LayoutRect(LayoutRect::infiniteIntRect()));

[Nico, 2017/02/17 21:14:24]

https://build.chromium.org/p/chromium.fyi/builders/Linux%20ARM/builds/34587/s...

FAILED: obj/third_party/WebKit/Source/core/paint/paint_1/PaintLayerClipper.o 
/b/c/cipd/goma/gomacc ../../third_party/llvm-build/Release+Asserts/bin/clang++
-MMD -MF obj/third_party/WebKit/Source/core/paint/paint_1/PaintLayerClipper.o.d
-DV8_DEPRECATION_WARNINGS -DUSE_UDEV -DUI_COMPOSITOR_IMAGE_TRANSPORT
-DUSE_AURA=1 -DUSE_PANGO=1 -DUSE_CAIRO=1 -DUSE_GLIB=1 -DUSE_NSS_CERTS=1
-DUSE_X11=1 -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL
-DCHROMIUM_BUILD -DENABLE_MEDIA_ROUTER=1 -DFIELDTRIAL_TESTING_ENABLED
-DCR_CLANG_REVISION=\"289944-2\" -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE
-D_LARGEFILE64_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -DNDEBUG
-DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -DBLINK_CORE_IMPLEMENTATION=1
-DGL_GLEXT_PROTOTYPES -DUSE_GLX -DUSE_EGL -DBLINK_IMPLEMENTATION=1
-DINSIDE_BLINK -DSK_IGNORE_DW_GRAY_FIX -DSK_IGNORE_DIRECTWRITE_GASP_FIX
-DSK_IGNORE_LINEONLY_AA_CONVEX_PATH_OPTS -DSK_SUPPORT_GPU=1
-DENABLE_LAYOUT_UNIT_IN_INLINE_BOXES=0 -DENABLE_OILPAN=1
-DWTF_USE_CONCATENATED_IMPULSE_RESPONSES=1 -DWTF_USE_WEBAUDIO_FFMPEG=1
-DWTF_USE_DEFAULT_RENDER_THEME=1 -DU_USING_ICU_NAMESPACE=0 -DU_ENABLE_DYLOAD=0
-DU_STATIC_IMPLEMENTATION -DICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_FILE
-DLIBXSLT_STATIC -I../.. -Igen -I../../third_party/WebKit/Source
-I../../third_party/WebKit -Igen/blink -Igen/third_party/WebKit
-I../../third_party/khronos -I../../gpu
-I../../build/linux/debian_wheezy_arm-sysroot/usr/include/glib-2.0
-I../../build/linux/debian_wheezy_arm-sysroot/usr/lib/arm-linux-gnueabihf/glib-2.0/include
-I../../third_party/libwebp -I../../third_party/WebKit/Source -Igen/blink
-I../../skia/config -I../../skia/ext -I../../third_party/skia/include/c
-I../../third_party/skia/include/config -I../../third_party/skia/include/core
-I../../third_party/skia/include/effects -I../../third_party/skia/include/images
-I../../third_party/skia/include/lazy -I../../third_party/skia/include/pathops
-I../../third_party/skia/include/pdf -I../../third_party/skia/include/pipe
-I../../third_party/skia/include/ports -I../../third_party/skia/include/utils
-I../../third_party/skia/include/gpu -I../../third_party/skia/src/gpu
-I../../third_party/skia/src/sksl -I../../third_party/icu/source/common
-I../../third_party/icu/source/i18n -I../../third_party/angle/include
-I../../third_party/angle/src/common/third_party/numerics -Igen/angle
-I../../third_party/iccjpeg -I../../third_party/libpng -I../../third_party/zlib
-I../../third_party/libxml/src/include -I../../third_party/libxml/linux/include
-I../../third_party/libxslt -I../../third_party/ots/include
-I../../third_party/snappy/src -I../../third_party/snappy/linux
-I../../v8/include -Igen/v8/include -fno-strict-aliasing
--param=ssp-buffer-size=4 -fstack-protector -Wno-builtin-macro-redefined
-D__DATE__= -D__TIME__= -D__TIMESTAMP__= -funwind-tables -fPIC -pipe
-fcolor-diagnostics -fdebug-prefix-map=/mnt/data/b/c/b/Linux_ARM/src=.
--target=arm-linux-gnueabihf -march=armv7-a -mfloat-abi=hard
-mtune=generic-armv7-a -pthread -mfpu=neon -mthumb -Wall -Werror -Wextra
-Wno-missing-field-initializers -Wno-unused-parameter -Wno-c++11-narrowing
-Wno-covered-switch-default -Wno-deprecated-register
-Wno-unneeded-internal-declaration -Wno-inconsistent-missing-override
-Wno-shift-negative-value -Wno-undefined-var-template
-Wno-nonportable-include-path -Wno-address-of-packed-member
-Wno-block-capture-autoreleasing -O2 -fno-ident -fdata-sections
-ffunction-sections -g0 --sysroot=../../build/linux/debian_wheezy_arm-sysroot
-fvisibility=hidden -Xclang -load -Xclang
../../third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.so -Xclang
-add-plugin -Xclang find-bad-constructs -Xclang -plugin-arg-find-bad-constructs
-Xclang check-ipc -Wheader-hygiene -Wstring-conversion
-Wtautological-overlap-compare -Wexit-time-destructors -Xclang -load -Xclang
../../third_party/llvm-build/Release+Asserts/lib/libBlinkGCPlugin.so -Xclang
-add-plugin -Xclang blink-gc-plugin -Wglobal-constructors -DLIBXML_STATIC=
-fvisibility-inlines-hidden -std=gnu++11 -fno-rtti -fno-exceptions -c
../../third_party/WebKit/Source/core/paint/PaintLayerClipper.cpp -o
obj/third_party/WebKit/Source/core/paint/paint_1/PaintLayerClipper.o
../../third_party/WebKit/Source/core/paint/PaintLayerClipper.cpp:514:32: error:
member reference type 'blink::LayoutBoxModelObject' is not a pointer; did you
mean to use '.'?
    if (!m_layer.layoutObject()->paintProperties())
         ~~~~~~~~~~~~~~~~~~~~~~^~
                               .
1 error generated.


Not sure why only the linux/arm bot shouts about this; maybe it makes sense to
you?

+
     ClipRect backgroundClipRect = clipRectWithGeometryMapper(context, false);
 #ifdef CHECK_CLIP_RECTS
     ClipRect testBackgroundClipRect =