Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(759)

Issue 2702763002: Remove up-mixing* and stereo2mono-down-mixing tests (Closed)

Created:
3 years, 10 months ago by Raymond Toy
Modified:
3 years, 10 months ago
Reviewers:
hongchan
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove up-mixing* and stereo2mono-down-mixing tests These tests are covered by AudioNode/audionode-channel-rules.html which is a much more complete test of the mixing rules. stereo2mono-down-mixing was testing that a stereo source downmixed to mono by the destination doesn't crash. This is also covered by audionode-channel-rules which tests downmixing of any channel arrangements to a mono destination. BUG=693256 TEST=none Review-Url: https://codereview.chromium.org/2702763002 Cr-Commit-Position: refs/heads/master@{#452982} Committed: https://chromium.googlesource.com/chromium/src/+/bc8f880eb1ad53ca001981ebacd4569b91c61379

Patch Set 1 #

Messages

Total messages: 8 (4 generated)
Raymond Toy
PTAL
3 years, 10 months ago (2017-02-22 23:13:19 UTC) #2
hongchan
lgtm
3 years, 10 months ago (2017-02-24 22:03:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2702763002/1
3 years, 10 months ago (2017-02-24 22:05:40 UTC) #5
commit-bot: I haz the power
3 years, 10 months ago (2017-02-24 23:11:25 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/bc8f880eb1ad53ca001981ebacd4...

Powered by Google App Engine
This is Rietveld 408576698