Issue 270273006: GameBench: curCell doesn't need to be extra state.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 270273006: GameBench: curCell doesn't need to be extra state. (Closed)

Created:
6 years, 7 months ago by mtklein_C

Modified:
6 years, 7 months ago

Reviewers:
mtklein, robertphillips

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlesource.com/skia.git@master

Visibility:
Public.

More Reviews

Description

GameBench: curCell doesn't need to be extra state. We're using a static curCell to loop around the atlas. We can just use i. Noticed this when TSAN complained about it. Parallel invocations of the game bench were stomping on each other's curCell. BUG=skia:1792 Committed: http://code.google.com/p/skia/source/detail?r=14617

Patch Set 1 #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -2 lines)			Patch
	M	bench/GameBench.cpp	View		1 chunk	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/270273006/1

6 years, 7 months ago (2014-05-07 17:06:25 UTC) #4

Message was sent while issue was closed.

Change committed as 14617

Expand Messages | Collapse Messages