bench/GameBench.cpp - Issue 270273006: GameBench: curCell doesn't need to be extra state.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: bench/GameBench.cpp

Issue 270273006: GameBench: curCell doesn't need to be extra state. (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: bench/GameBench.cpp

diff --git a/bench/GameBench.cpp b/bench/GameBench.cpp

index 839440b612e0dd4ffaa6719be75f866c651caddf..c0a0e1b1b3e21fdab41c8188766442b8adc9b1f3 100644

--- a/bench/GameBench.cpp

+++ b/bench/GameBench.cpp

@@ -190,9 +190,8 @@ protected:

canvas->concat(mat);

if (fUseAtlas) {

- static int curCell = 0;

+ const int curCell = i % (kNumAtlasedX * kNumAtlasedY);

SkIRect src = fAtlasRects[curCell % (kNumAtlasedX)][curCell / (kNumAtlasedX)];

- curCell = (curCell + 1) % (kNumAtlasedX*kNumAtlasedY);

if (fUseDrawVertices) {

SkPoint uvs[4] = {

« no previous file with comments | « no previous file | no next file » | no next file with comments »