Extract kArcEnabled preference from ArcSessionManager part 1.

chrome/common/pref_names.cc

Index: chrome/common/pref_names.cc
diff --git a/chrome/common/pref_names.cc b/chrome/common/pref_names.cc
index 65421df7b16e998e611f820caf0ee088d49bb601..52fb2502e8289d083d4957b201cbf59200b83d4f 100644
--- a/chrome/common/pref_names.cc
+++ b/chrome/common/pref_names.cc
@@ -28,7 +28,8 @@ const char kArcDataRemoveRequested[] = "arc.data.remove_requested";
 // Store on ARC.
 // TODO(hidehiko): For historical reason, now the preference name does not
 // directly reflect "Google Play Store". We should get and set the values via
-// utility methods (IsArcPlayStoreEnabled() and SetArcPlayStoreEnabled()).
+// utility methods (IsArcPlayStoreEnabledForProfile() and

[Yusuke Sato, 2017/02/17 22:27:09]

Please also mention that the functions are in c/b/c/arc_util.h.

[hidehiko, 2017/02/20 18:18:45]

Done, but I'm not very sure if it is a good practice, considering we may want to
move them in future, TBH, so maybe cs is a tool for it? Anyway, done.

[Yusuke Sato, 2017/02/21 20:59:43]

File names are not necessary especially when the method name in a comment is
long enough like ClassName::MethodName(). In this case, I felt like more
clarification might be helpful because the functions mentioned here are not in a
class, and we haven't fully cleaned up confusing function names in other places
just yet. I mean, we've changed method names and places for this type of things
probably too many times already and I wanted to avoid further confusion at some
cost.

+// SetArcPlayStoreEnabledForProfile()).

[hidehiko, 2017/02/17 15:07:19]

FYI: I haven't addressed this in this CL, so there still are several places
where kArcEnabled is directly used (specifically on testing).

A following CL will extract preference change handling from ArcSessionManager,
then several such code can/should be changed to
ArcSessionManager::Request{Enable/Disble} instead of current direct kArcEnabled
operation. I'll take a look at them, along with (or after) that change.

 const char kArcEnabled[] = "arc.enabled";
 // A preference that indicated whether Android reported that it's compliant
 // with provided policies. When it's compliant, Android kiosk app will start.