Extract kArcEnabled preference from ArcSessionManager part 1.

chrome/common/pref_names.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/common/pref_names.h"
 
 #include "base/macros.h"
 #include "build/build_config.h"
 #include "chrome/common/features.h"
 #include "chrome/common/pref_font_webkit_names.h"
@@ skipping 10 matching lines @@
 // A preference to keep list of Android apps and their state.
 const char kArcApps[] = "arc.apps";
 // A preference to store backup and restore state for Android apps.
 const char kArcBackupRestoreEnabled[] = "arc.backup_restore.enabled";
 // A preference to indicate that Android's data directory should be removed.
 const char kArcDataRemoveRequested[] = "arc.data.remove_requested";
 // A preference representing whether a user has opted in to use Google Play
 // Store on ARC.
 // TODO(hidehiko): For historical reason, now the preference name does not
 // directly reflect "Google Play Store". We should get and set the values via
-// utility methods (IsArcPlayStoreEnabled() and SetArcPlayStoreEnabled()).
+// utility methods (IsArcPlayStoreEnabledForProfile() and

[Yusuke Sato, 2017/02/17 22:27:09]

Please also mention that the functions are in c/b/c/arc_util.h.

[hidehiko, 2017/02/20 18:18:45]

Done, but I'm not very sure if it is a good practice, considering we may want to
move them in future, TBH, so maybe cs is a tool for it? Anyway, done.

[Yusuke Sato, 2017/02/21 20:59:43]

File names are not necessary especially when the method name in a comment is
long enough like ClassName::MethodName(). In this case, I felt like more
clarification might be helpful because the functions mentioned here are not in a
class, and we haven't fully cleaned up confusing function names in other places
just yet. I mean, we've changed method names and places for this type of things
probably too many times already and I wanted to avoid further confusion at some
cost.

+// SetArcPlayStoreEnabledForProfile()).

[hidehiko, 2017/02/17 15:07:19]

FYI: I haven't addressed this in this CL, so there still are several places
where kArcEnabled is directly used (specifically on testing).

A following CL will extract preference change handling from ArcSessionManager,
then several such code can/should be changed to
ArcSessionManager::Request{Enable/Disble} instead of current direct kArcEnabled
operation. I'll take a look at them, along with (or after) that change.

 const char kArcEnabled[] = "arc.enabled";
 // A preference that indicated whether Android reported that it's compliant
 // with provided policies. When it's compliant, Android kiosk app will start.
 const char kArcPolicyCompliant[] = "arc.policy_compliant";
 // A preference that indicates that user accepted PlayStore terms.
 const char kArcTermsAccepted[] = "arc.terms.accepted";
 // A preference to keep user's consent to use location service.
 const char kArcLocationServiceEnabled[] = "arc.location_service.enabled";
 // A preference to keep list of Android packages and their infomation.
 const char kArcPackages[] = "arc.packages";
@@ skipping 2406 matching lines @@
 
 // Number of times user has seen the "desktop to iOS" history page promotion.
 const char kNumberHistoryPageIOSPromoShown[] =
     "history_page_ios_promo_shown_count";
 
 // True if the user has dismissed the "desktop to iOS" history page promotion.
 const char kHistoryPageIOSPromoDismissed[] = "history_page_ios_promo_dismissed";
 #endif
 
 }  // namespace prefs