Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issue 2702683002: [Mac RTL] Fix text alignment in the security bubble. (Closed)

Created:
3 years, 10 months ago by Avi (use Gerrit)
Modified:
3 years, 10 months ago
Reviewers:
erikchen
CC:
chromium-reviews, mac-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Mac RTL] Fix text alignment in the security bubble. BUG=693303 TEST=as in bug Review-Url: https://codereview.chromium.org/2702683002 Cr-Commit-Position: refs/heads/master@{#451232} Committed: https://chromium.googlesource.com/chromium/src/+/4ba96148ab4fea7ae4f535c7e7bfdb37d9daf027

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M chrome/browser/ui/cocoa/location_bar/security_state_bubble_decoration.mm View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
Avi (use Gerrit)
PTAL. Screenshots are in the bug.
3 years, 10 months ago (2017-02-17 02:59:28 UTC) #4
erikchen
lgtm
3 years, 10 months ago (2017-02-17 03:31:38 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2702683002/1
3 years, 10 months ago (2017-02-17 04:07:39 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromeos_daisy_chromium_compile_only_ng on ...
3 years, 10 months ago (2017-02-17 04:50:50 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2702683002/1
3 years, 10 months ago (2017-02-17 05:20:58 UTC) #12
commit-bot: I haz the power
3 years, 10 months ago (2017-02-17 05:46:13 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/4ba96148ab4fea7ae4f535c7e7bf...

Powered by Google App Engine
This is Rietveld 408576698