Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 2702633002: color: Remove implied color space (Closed)

Created:
3 years, 10 months ago by ccameron
Modified:
3 years, 10 months ago
Reviewers:
chrishtr
CC:
chromium-reviews, krit, drott+blinkwatch_chromium.org, blink-reviews-platform-graphics_chromium.org, Stephen Chennney, dshwang, pdr+graphicswatchlist_chromium.org, jbroman, Justin Novosad, blink-reviews-api_chromium.org, danakj+watch_chromium.org, dglazkov+blink, Rik, f(malita), blink-reviews, cc-bugs_chromium.org, ajuma+watch_chromium.org, kinuko+watch, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

color: Remove implied color space This is no longer a needed concept, now that we will be using Skia's color conversion at rasterization time. BUG=667411 TBR=chrishtr CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2702633002 Cr-Commit-Position: refs/heads/master@{#452405} Committed: https://chromium.googlesource.com/chromium/src/+/76f24f08581342212fcd7b74717fb6a4960b486a

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -80 lines) Patch
M cc/blink/web_display_item_list_impl.h View 1 chunk +0 lines, -2 lines 0 comments Download
M cc/blink/web_display_item_list_impl.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M cc/playback/display_item_list.h View 2 chunks +0 lines, -13 lines 0 comments Download
M cc/playback/raster_source.h View 1 2 chunks +0 lines, -12 lines 0 comments Download
M cc/playback/raster_source.cc View 1 1 chunk +0 lines, -8 lines 0 comments Download
M cc/raster/bitmap_raster_buffer_provider.cc View 1 chunk +1 line, -5 lines 0 comments Download
M cc/raster/gpu_raster_buffer_provider.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/raster/one_copy_raster_buffer_provider.cc View 1 chunk +1 line, -5 lines 0 comments Download
M cc/raster/zero_copy_raster_buffer_provider.cc View 1 chunk +1 line, -5 lines 0 comments Download
M cc/resources/resource_provider.h View 1 chunk +0 lines, -1 line 0 comments Download
M cc/resources/resource_provider.cc View 2 chunks +1 line, -3 lines 0 comments Download
M cc/tiles/tile_manager.cc View 1 1 chunk +4 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/ContentLayerDelegate.cpp View 1 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/public/platform/WebDisplayItemList.h View 2 chunks +0 lines, -10 lines 0 comments Download

Messages

Total messages: 9 (6 generated)
ccameron
The next step will be to clean up some of the ColorBehavior instances (but they're ...
3 years, 10 months ago (2017-02-16 23:23:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2702633002/20001
3 years, 10 months ago (2017-02-23 03:48:16 UTC) #6
commit-bot: I haz the power
3 years, 10 months ago (2017-02-23 05:25:24 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/76f24f08581342212fcd7b74717f...

Powered by Google App Engine
This is Rietveld 408576698