Add support for reading USB descriptors to the new Windows backend.

Add support for reading USB descriptors to the new Windows backend.

This patch adds support to the new Windows USB backend for reading the
device, configuration and string descriptors from a device. This is done
by making requests to the USB hub driver and usually returns cached
information but could make actual requests to the device and so full
support for overlapped I/O is present.

This will form the basis for full I/O handling in later patches.

BUG=422562
Review-Url: https://codereview.chromium.org/2702623002
Cr-Commit-Position: refs/heads/master@{#451442}
Committed: https://chromium.googlesource.com/chromium/src/+/d0a10f5b8c0fa1312be688ca3a68cf240ab7f874

[Reilly Grant (use Gerrit), 2017-02-16 23:01:07]

The CQ bit was checked by reillyg@chromium.org to run a CQ dry run

[Reilly Grant (use Gerrit), 2017-02-16 23:01:58]

reillyg@chromium.org changed reviewers:
+ rockot@chromium.org

[Reilly Grant (use Gerrit), 2017-02-16 23:01:59]

PTAL

[Reilly Grant (use Gerrit), 2017-02-16 23:02:20]

Description was changed from

==========
Add support for reading USB descriptors to the new Windows backend.

This patch adds support to the new Windows USB backend for reading the
device, configuration and string descriptors for a device. This is done
by making requests to the USB hub driver and usually returns cached
information but could make actual requests to the device and so full
support for overlapped I/O is present.

This will form the basis for full I/O handling in later patches.

BUG=422562
==========

to

==========
Add support for reading USB descriptors to the new Windows backend.

This patch adds support to the new Windows USB backend for reading the
device, configuration and string descriptors from a device. This is done
by making requests to the USB hub driver and usually returns cached
information but could make actual requests to the device and so full
support for overlapped I/O is present.

This will form the basis for full I/O handling in later patches.

BUG=422562
==========

[commit-bot: I haz the power, 2017-02-16 23:04:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-17 02:24:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-17 02:24:28]

Dry run: This issue passed the CQ dry run.

[Ken Rockot(use gerrit already), 2017-02-17 20:27:07]

lgtm

https://codereview.chromium.org/2702623002/diff/1/device/usb/usb_device_handl...
File device/usb/usb_device_handle_win.cc (right):

https://codereview.chromium.org/2702623002/diff/1/device/usb/usb_device_handl...
device/usb/usb_device_handle_win.cc:184: auto* node_connection_info = new
USB_NODE_CONNECTION_INFORMATION_EX;
nit: use a unique_ptr and explicitly release it to base::Owned below?

https://codereview.chromium.org/2702623002/diff/1/device/usb/usb_device_handl...
device/usb/usb_device_handle_win.cc:186: requests_.emplace_back(new
Request(hub_handle_.Get()));
nit: here and elsewhere, consider using base::MakeUnique<Request> instead of new

https://codereview.chromium.org/2702623002/diff/1/device/usb/usb_device_handl...
File device/usb/usb_device_handle_win.h (right):

https://codereview.chromium.org/2702623002/diff/1/device/usb/usb_device_handl...
device/usb/usb_device_handle_win.h:118: std::list<std::unique_ptr<Request>>
requests_;
nit: Maybe worth documenting that hub_handle_ must outlive requests_.

Also consider using a map<Request*, std::unique_ptr<Request>>?

[Reilly Grant (use Gerrit), 2017-02-18 00:45:25]

Addressed rockot@'s feedback and rebased.

[Reilly Grant (use Gerrit), 2017-02-18 00:45:49]

https://codereview.chromium.org/2702623002/diff/1/device/usb/usb_device_handl...
File device/usb/usb_device_handle_win.cc (right):

https://codereview.chromium.org/2702623002/diff/1/device/usb/usb_device_handl...
device/usb/usb_device_handle_win.cc:184: auto* node_connection_info = new
USB_NODE_CONNECTION_INFORMATION_EX;
On 2017/02/17 20:27:07, Ken Rockot wrote:
> nit: use a unique_ptr and explicitly release it to base::Owned below?

It ends up being really awkward because I need the raw pointer 3 places in the
statement below and so expression evaluation order becomes an issue.

https://codereview.chromium.org/2702623002/diff/1/device/usb/usb_device_handl...
device/usb/usb_device_handle_win.cc:186: requests_.emplace_back(new
Request(hub_handle_.Get()));
On 2017/02/17 20:27:07, Ken Rockot wrote:
> nit: here and elsewhere, consider using base::MakeUnique<Request> instead of
new

Done.

https://codereview.chromium.org/2702623002/diff/1/device/usb/usb_device_handl...
File device/usb/usb_device_handle_win.h (right):

https://codereview.chromium.org/2702623002/diff/1/device/usb/usb_device_handl...
device/usb/usb_device_handle_win.h:118: std::list<std::unique_ptr<Request>>
requests_;
On 2017/02/17 20:27:07, Ken Rockot wrote:
> nit: Maybe worth documenting that hub_handle_ must outlive requests_.
> 
> Also consider using a map<Request*, std::unique_ptr<Request>>?

Done.

[Reilly Grant (use Gerrit), 2017-02-18 00:46:01]

The CQ bit was checked by reillyg@chromium.org

[Reilly Grant (use Gerrit), 2017-02-18 00:46:01]

The patchset sent to the CQ was uploaded after l-g-t-m from rockot@chromium.org
Link to the patchset: https://codereview.chromium.org/2702623002/#ps20001
(title: "Addressed rockot@'s feedback and rebased.")

[commit-bot: I haz the power, 2017-02-18 00:47:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-18 02:50:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-18 02:50:14]

Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
no build URL)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
no build URL)

[Reilly Grant (use Gerrit), 2017-02-18 07:35:15]

The CQ bit was checked by reillyg@chromium.org

[commit-bot: I haz the power, 2017-02-18 07:35:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-18 07:40:12]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1487403315229090,
"parent_rev": "91bfdf3e5fd8b4403f1a346552c0ad991c52913d", "commit_rev":
"d0a10f5b8c0fa1312be688ca3a68cf240ab7f874"}

[commit-bot: I haz the power, 2017-02-18 07:40:49]

Description was changed from

==========
Add support for reading USB descriptors to the new Windows backend.

This patch adds support to the new Windows USB backend for reading the
device, configuration and string descriptors from a device. This is done
by making requests to the USB hub driver and usually returns cached
information but could make actual requests to the device and so full
support for overlapped I/O is present.

This will form the basis for full I/O handling in later patches.

BUG=422562
==========

to

==========
Add support for reading USB descriptors to the new Windows backend.

This patch adds support to the new Windows USB backend for reading the
device, configuration and string descriptors from a device. This is done
by making requests to the USB hub driver and usually returns cached
information but could make actual requests to the device and so full
support for overlapped I/O is present.

This will form the basis for full I/O handling in later patches.

BUG=422562

Review-Url: https://codereview.chromium.org/2702623002
Cr-Commit-Position: refs/heads/master@{#451442}
Committed:
https://chromium.googlesource.com/chromium/src/+/d0a10f5b8c0fa1312be688ca3a68...
==========

[commit-bot: I haz the power, 2017-02-18 07:40:50]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/d0a10f5b8c0fa1312be688ca3a68...