chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.html - Issue 2702523005: MD Settings: long dialog body should have overscroll line.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.html

Issue 2702523005: MD Settings: long dialog body should have overscroll line. (Closed)

Patch Set: revert format change Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/browser/resources/settings/languages_page/add_languages_dialog.html » ('j') | chrome/browser/resources/settings/passwords_and_forms_page/address_edit_dialog.html » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.html

diff --git a/chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.html b/chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.html

index 93472c082c91fe5e2e3c5c990cf0ad9237a15240..099ed17e927277b204a5408cf50e0d894ed161ba 100644

--- a/chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.html

+++ b/chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.html

@@ -19,7 +19,6 @@

}

#dialog .button-container {

- border-top: 1px solid rgba(0, 0, 0, 0.14);

margin-top: 0;

padding-top: 10px;

}

@@ -89,17 +88,22 @@

* Replace the bottom margin with padding to avoid the gap between

* the scrollbar and the bottom separator. */

@media all and (max-height: 724px) {

+ #dialog {

+ /* crbug.com/652027: Show four and a *half* items in the list. */

+ --cr-dialog-body-container: {

+ max-height: 280px;

+ };

+ }

#dialog .body {

margin-bottom: 0;

- /* crbug.com/652027: Show four and a *half* items in the list. */

- max-height: 280px;

- overflow-y: scroll;

padding-bottom: 12px;

}

</style>

- <dialog is="cr-dialog" id="dialog" close-text="$i18n{close}" ignore-popstate>

+ <dialog is="cr-dialog" id="dialog" close-text="$i18n{close}"

+ show-scroll-borders ignore-popstate>

<div class="title">$i18n{clearBrowsingData}</div>