chrome/browser/resources/settings/passwords_and_forms_page/address_edit_dialog.html - Issue 2702523005: MD Settings: long dialog body should have overscroll line.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/passwords_and_forms_page/address_edit_dialog.html

Issue 2702523005: MD Settings: long dialog body should have overscroll line. (Closed)

Patch Set: revert format change Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/settings/languages_page/compiled_resources2.gyp ('k') | chrome/test/data/webui/cr_elements/cr_dialog_test.js » ('j') | ui/webui/resources/cr_elements/cr_dialog/cr_dialog.html » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/passwords_and_forms_page/address_edit_dialog.html

diff --git a/chrome/browser/resources/settings/passwords_and_forms_page/address_edit_dialog.html b/chrome/browser/resources/settings/passwords_and_forms_page/address_edit_dialog.html

index 085505e394f778d2d5d3ecd046dc7fc50d21661c..7fc866f079b5baac6e5df4d3331e69933abf59e1 100644

--- a/chrome/browser/resources/settings/passwords_and_forms_page/address_edit_dialog.html

+++ b/chrome/browser/resources/settings/passwords_and_forms_page/address_edit_dialog.html

@@ -1,4 +1,5 @@

+<link rel="import" href="chrome://resources/cr_elements/cr_scrollable_behavior.html">

@@ -56,16 +57,19 @@

-webkit-margin-start: 8px;

}

- #dialog .body {

- max-height: 450px;

+ #dialog {

+ --cr-dialog-body-container: {

+ max-height: 450px;

+ };

}

@media all and (max-height: 714px) {

- #dialog .body {

- max-height: 270px;

+ #dialog {

+ --cr-dialog-body-container: {

+ max-height: 270px;

+ };

}

dpapad 2017/03/30 18:25:00 Blank line between CSS rules missing?

scottchen 2017/03/30 19:24:34 Done.

paper-textarea {

/**

* Workaround for iron-autogrow-textarea's display:inline-block creating

@@ -76,7 +80,8 @@

};

}

</style>

- <dialog is="cr-dialog" id="dialog" close-text="$i18n{close}">

+ <dialog is="cr-dialog" id="dialog" close-text="$i18n{close}"

+ show-scroll-borders>

<div class="title">[[title_]]</div>