Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Issue 2702463004: Re-display chrome:// page location icon label after aborted search (Closed)

Created:
3 years, 10 months ago by Evan Stade
Modified:
3 years, 10 months ago
Reviewers:
Peter Kasting
CC:
chromium-reviews, tfarina
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Re-display chrome:// page location icon label after aborted search This changes the behavior of chrome:// (and extension pages) to match the behavior of secure pages (showing ev certs). input_in_progress() matches what we do for the security chip, i.e. is used as the check inside GetToolbarModel()->GetSecurityLevel(false). BUG=691917 Review-Url: https://codereview.chromium.org/2702463004 Cr-Commit-Position: refs/heads/master@{#451078} Committed: https://chromium.googlesource.com/chromium/src/+/d8d55fefdb0bcf5b7d25b7a4fb673731ac6a8b9a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/browser/ui/views/location_bar/location_bar_view.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Evan Stade
3 years, 10 months ago (2017-02-16 02:40:14 UTC) #2
Peter Kasting
This doesn't cause us to display location text on the new tab page, does it? ...
3 years, 10 months ago (2017-02-16 06:39:19 UTC) #3
Evan Stade
On 2017/02/16 06:39:19, Peter Kasting wrote: > This doesn't cause us to display location text ...
3 years, 10 months ago (2017-02-16 19:10:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2702463004/1
3 years, 10 months ago (2017-02-16 19:11:53 UTC) #6
commit-bot: I haz the power
3 years, 10 months ago (2017-02-16 20:18:12 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d8d55fefdb0bcf5b7d25b7a4fb67...

Powered by Google App Engine
This is Rietveld 408576698