Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 2702423003: [DirectoryOwnership] Add TEAM/COMPONENT into OWNERS files. (Closed)

Created:
3 years, 10 months ago by ymzhang1
Modified:
3 years, 9 months ago
Reviewers:
palmer, gone
CC:
agrieve+watch_chromium.org, cbentzel+watch_chromium.org, chromium-reviews, darin-cc_chromium.org, jam, net-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DirectoryOwnership] Add TEAM/COMPONENT into OWNERS files. We are adding COMPONENT/TEAM information into OWNERS file. Please help us to verify the added TEAM/COMPONENT or suggest the correct TEAM/COMPONENT in your OWNERS files. Thanks. Proposal to add TEAM/COMPONENT information into OWNERS files http://bit.ly/add-team-component-proposal Proposal about how to get suggested component for directory. http://bit.ly/directory-mapping-proposal TEAM-COMPONENT mapping http://bit.ly/component-team-mapping Additional Information: Component lists https://bugs.chromium.org/p/chromium/adminComponents BUG=679905 Review-Url: https://codereview.chromium.org/2702423003 Cr-Commit-Position: refs/heads/master@{#456938} Committed: https://chromium.googlesource.com/chromium/src/+/304bef4f5c6502b7a863bb7be2c956ff1fd1420f

Patch Set 1 : update component #

Total comments: 6

Patch Set 2 : update component/team #

Patch Set 3 : update component/team #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M content/public/android/java/src/org/chromium/content/browser/crypto/OWNERS View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/crypto/OWNERS View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 18 (10 generated)
ymzhang1
Hello, We are adding COMPONENT/TEAM information into OWNERS file. Would you mind helping us to ...
3 years, 10 months ago (2017-02-21 21:47:24 UTC) #3
palmer
https://codereview.chromium.org/2702423003/diff/40001/components/security_state/OWNERS File components/security_state/OWNERS (right): https://codereview.chromium.org/2702423003/diff/40001/components/security_state/OWNERS#newcode4 components/security_state/OWNERS:4: # COMPONENT: Internals>CertAnalysis I think this one should be ...
3 years, 10 months ago (2017-02-21 22:11:06 UTC) #5
ymzhang1
https://codereview.chromium.org/2702423003/diff/40001/components/security_state/OWNERS File components/security_state/OWNERS (right): https://codereview.chromium.org/2702423003/diff/40001/components/security_state/OWNERS#newcode4 components/security_state/OWNERS:4: # COMPONENT: Internals>CertAnalysis On 2017/02/21 22:11:05, palmer wrote: > ...
3 years, 10 months ago (2017-02-21 22:16:18 UTC) #6
ymzhang1
moved ssl related OWNERS files to https://codereview.chromium.org/2746523002/.
3 years, 9 months ago (2017-03-13 20:33:52 UTC) #11
gone
I don't know what I'm supposed to be reviewing here; palmer@ already started.
3 years, 9 months ago (2017-03-14 18:16:26 UTC) #12
palmer
lgtm
3 years, 9 months ago (2017-03-14 18:22:22 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2702423003/140001
3 years, 9 months ago (2017-03-14 23:55:34 UTC) #15
commit-bot: I haz the power
3 years, 9 months ago (2017-03-15 01:26:55 UTC) #18
Message was sent while issue was closed.
Committed patchset #3 (id:140001) as
https://chromium.googlesource.com/chromium/src/+/304bef4f5c6502b7a863bb7be2c9...

Powered by Google App Engine
This is Rietveld 408576698