Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(308)

Issue 2702413003: [Chromecast] cast_shell_browsertests need chromecast_locales. (Closed)

Created:
3 years, 10 months ago by mbjorge
Modified:
3 years, 10 months ago
Reviewers:
slan, alokp
CC:
alokp+watch_chromium.org, chromium-reviews, halliwell+watch_chromium.org, lcwu+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Chromecast] cast_shell_browsertests need chromecast_locales. cast_shell_browsertests require the chromecsat_locales. These were getting built implicitly because most builders build cast_shell before running the tests. The ASAN/MSAN/TSAN builders do not build cast_shell though. Make the dependency explicit. BUG=internal b/35627608 TEST=cast_shell_browsertests Review-Url: https://codereview.chromium.org/2702413003 Cr-Commit-Position: refs/heads/master@{#452221} Committed: https://chromium.googlesource.com/chromium/src/+/ffa03d80bf40825e68b51bc270472028ebfb760f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M chromecast/BUILD.gn View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
mbjorge
3 years, 10 months ago (2017-02-21 21:14:34 UTC) #2
mbjorge
frienldy ping
3 years, 10 months ago (2017-02-22 18:56:37 UTC) #4
slan
lgtm
3 years, 10 months ago (2017-02-22 18:58:09 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2702413003/1
3 years, 10 months ago (2017-02-22 18:59:16 UTC) #7
commit-bot: I haz the power
3 years, 10 months ago (2017-02-22 21:53:29 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ffa03d80bf40825e68b51bc27047...

Powered by Google App Engine
This is Rietveld 408576698