Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2702403013:
Make HashTraits<QualifiedName>::emptyValue return a const reference (Closed)
DescriptionMake HashTraits<QualifiedName>::emptyValue return a const reference
This avoids unnecessary construction of a temporary object, saving a few
cycles and some code-space (~2k on x86-64.)
Also inline QualifiedName::null for some additional savings.
Review-Url: https://codereview.chromium.org/2702403013
Cr-Commit-Position: refs/heads/master@{#455069}
Committed: https://chromium.googlesource.com/chromium/src/+/6e888a3ff001229b5dc093c2b9186193c821f903
Patch Set 1 #Patch Set 2 : Add CORE_EXPORT #Patch Set 3 : Move export qualifier #Patch Set 4 : Move const qualifier #Patch Set 5 : extern declaration in the global scope #Patch Set 6 : Try another position of the export macro #Patch Set 7 : Global #
Total comments: 2
Patch Set 8 : Default inline null() #
Messages
Total messages: 40 (34 generated)
The CQ bit was checked by fs@opera.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by fs@opera.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
The CQ bit was checked by fs@opera.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by fs@opera.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
The CQ bit was checked by fs@opera.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by fs@opera.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by fs@opera.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
fs@opera.com changed reviewers: + sigbjornf@opera.com
https://codereview.chromium.org/2702403013/diff/120001/third_party/WebKit/Sou... File third_party/WebKit/Source/core/dom/QualifiedName.h (right): https://codereview.chromium.org/2702403013/diff/120001/third_party/WebKit/Sou... third_party/WebKit/Source/core/dom/QualifiedName.h:184: inline const QualifiedName& QualifiedName::null() { I'd prefer to define this 'inplace' with the static decl.
The CQ bit was checked by fs@opera.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
https://codereview.chromium.org/2702403013/diff/120001/third_party/WebKit/Sou... File third_party/WebKit/Source/core/dom/QualifiedName.h (right): https://codereview.chromium.org/2702403013/diff/120001/third_party/WebKit/Sou... third_party/WebKit/Source/core/dom/QualifiedName.h:184: inline const QualifiedName& QualifiedName::null() { On 2017/03/07 at 12:45:33, sof wrote: > I'd prefer to define this 'inplace' with the static decl. Done.
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by fs@opera.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 140001, "attempt_start_ts": 1488896847939400,
"parent_rev": "3f7b65bf0eb3679d45fe02578d71142ef2b4bffb", "commit_rev":
"6e888a3ff001229b5dc093c2b9186193c821f903"}
Message was sent while issue was closed.
Description was changed from ========== Make HashTraits<QualifiedName>::emptyValue return a const reference This avoids unnecessary construction of a temporary object, saving a few cycles and some code-space (~2k on x86-64.) Also inline QualifiedName::null for some additional savings. ========== to ========== Make HashTraits<QualifiedName>::emptyValue return a const reference This avoids unnecessary construction of a temporary object, saving a few cycles and some code-space (~2k on x86-64.) Also inline QualifiedName::null for some additional savings. Review-Url: https://codereview.chromium.org/2702403013 Cr-Commit-Position: refs/heads/master@{#455069} Committed: https://chromium.googlesource.com/chromium/src/+/6e888a3ff001229b5dc093c2b918... ==========
Message was sent while issue was closed.
Committed patchset #8 (id:140001) as https://chromium.googlesource.com/chromium/src/+/6e888a3ff001229b5dc093c2b918... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
