ui/gl/gl_surface.h - Issue 2702403009: Make surface GetFormat pure virtual, add missing overrides.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/gl/gl_surface.h

Issue 2702403009: Make surface GetFormat pure virtual, add missing overrides. (Closed)

Patch Set: Fix class name for Windows Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/gl/gl_surface.h

diff --git a/ui/gl/gl_surface.h b/ui/gl/gl_surface.h

index 270e0ca9b263f31840448447cd368d62e8a39440..fec580ba8e0a5014f934f25380d32483a6396f39 100644

--- a/ui/gl/gl_surface.h

+++ b/ui/gl/gl_surface.h

@@ -157,8 +157,10 @@ class GL_EXPORT GLSurface : public base::RefCounted<GLSurface> {

// with this GLSurface.

virtual unsigned long GetCompatibilityKey();

- // Get the GL pixel format of the surface, if available.

- virtual GLSurfaceFormat GetFormat();

+ // Get the GL pixel format of the surface. Must be implemented in a

+ // subclass, though it's ok to just "return GLSurfaceFormat()" if

+ // the default is appropriate.

+ virtual GLSurfaceFormat GetFormat() = 0;

// Get access to a helper providing time of recent refresh and period

// of screen refresh. If unavailable, returns NULL.

« no previous file with comments | « gpu/ipc/service/image_transport_surface_overlay_mac.mm ('k') | ui/gl/gl_surface.cc » ('j') | no next file with comments »